Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Implement version selector install guides #18835

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ys2843
Copy link
Contributor

@ys2843 ys2843 commented Jul 31, 2020

Description

fix #18833 and #18666
This PR includes the changes to create a comprehensive installation widget that covers all the versions.

Changes

  • Bring back missing installation guide contents

Comments

@ys2843 ys2843 requested review from aaronmarkham and szha as code owners July 31, 2020 21:56
@mxnet-bot
Copy link

Hey @ys2843 , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [centos-gpu, unix-cpu, edge, windows-gpu, windows-cpu, miscellaneous, sanity, clang, centos-cpu, unix-gpu, website]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@ys2843
Copy link
Contributor Author

ys2843 commented Jul 31, 2020

@mxnet-label-bot remove [pr-awaiting-review]

@lanking520 lanking520 added pr-awaiting-review PR is waiting for code review Website labels Jul 31, 2020
@ys2843
Copy link
Contributor Author

ys2843 commented Aug 2, 2020

@mxnet-bot run ci [unix-cpu, windows-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [unix-cpu, windows-gpu]

@ys2843 ys2843 force-pushed the website-installation-widget-patch branch from 7c0c47d to 1ccfb68 Compare August 2, 2020 20:26
Copy link
Contributor

@leezu leezu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ys2843. Let's remove the windows docker instructions, as they only exist in the codebase due to a symlink but are not supported and shouldn't be shown on the website.

I think the symlink would be removed as part of adding platform and version specific build from source instructions in #18666

@lanking520 lanking520 removed the pr-awaiting-review PR is waiting for code review label Aug 3, 2020
@ys2843 ys2843 marked this pull request as draft August 3, 2020 20:36
@ChaiBapchya
Copy link
Contributor

Thanks @leezu good catch!

@ys2843
Copy link
Contributor Author

ys2843 commented Aug 7, 2020

Thank you @ys2843. Let's remove the windows docker instructions, as they only exist in the codebase due to a symlink but are not supported and shouldn't be shown on the website.

I think the symlink would be removed as part of adding platform and version specific build from source instructions in #18666

@leezu Just to clarify, since we are going to have a unified installation widget that covers all versions. In which version we don't support windows/docker? Because if we still support them in previous versions, these symlink still need to be there. And we just hide windows/docker for some certain versions.

@ys2843 ys2843 force-pushed the website-installation-widget-patch branch from 7f9ad8c to 71b4186 Compare August 7, 2020 22:57
@ys2843 ys2843 marked this pull request as ready for review August 7, 2020 23:02
@ys2843 ys2843 changed the title fix installation widget missing contents Implement version selector install guides Aug 7, 2020
@ys2843 ys2843 marked this pull request as draft August 7, 2020 23:49
@ys2843 ys2843 mentioned this pull request Aug 10, 2020
@ys2843 ys2843 force-pushed the website-installation-widget-patch branch from 8c360cd to 12dd397 Compare August 21, 2020 21:12
@mseth10 mseth10 added the pr-work-in-progress PR is still work in progress label Mar 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-work-in-progress PR is still work in progress Website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Website] Get started Windows Docker missing instructions
6 participants