Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[OP] Move Elementwise binary scalar ops to SimpleOp Registry #1857

Merged
merged 6 commits into from
Apr 23, 2016

Conversation

tqchen
Copy link
Member

@tqchen tqchen commented Apr 15, 2016

No description provided.

@tqchen
Copy link
Member Author

tqchen commented Apr 15, 2016

cc @pluskid @Javelinjs

This PR cause a backward compatible break in symbolic API.

  • Overload of scalar - symbol
    • _DivScalar(lhs, scalar_on_left=true) is changed to _RDivScalar
  • Same stands for _RPowerScalar, _RMinusScalar

I have updated the python API, but maybe changes in julia and scala is needed if you overloaded the operator. Since these symbols are not frequently used, I plan to merge this in when ok

@yzhliu
Copy link
Member

yzhliu commented Apr 15, 2016

I'll fix it this weekend.

@tqchen
Copy link
Member Author

tqchen commented Apr 15, 2016

@Javelinjs please do a PR to my repo so the things can be fixed when I merge this in.

@thirdwing can you also do so for the R testcase?

@thirdwing
Copy link
Contributor

OK. I will do that tonight.

@tqchen
Copy link
Member Author

tqchen commented Apr 17, 2016

@thirdwing @Javelinjs any update on this?

[scala] operands change for SimpleOp Registry
@thirdwing
Copy link
Contributor

Sorry for the late reply. Working on a conference paper. Will update this
soon.

On Sun, Apr 17, 2016 at 1:49 AM, Tianqi Chen notifications@github.com
wrote:

@thirdwing https://github.com/thirdwing @Javelinjs
https://github.com/javelinjs any update on this?


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#1857 (comment)

Qiang Kou
qkou@umail.iu.edu
School of Informatics and Computing, Indiana University

@pluskid
Copy link
Contributor

pluskid commented Apr 20, 2016

I think it would be good to set a goal to introduce versioning into libmxnet. Then this kind of breaking changes will not be a disaster for other language bindings.

@tqchen
Copy link
Member Author

tqchen commented Apr 20, 2016

agreed

@tqchen
Copy link
Member Author

tqchen commented Apr 23, 2016

@thirdwing @pluskid @Javelinjs this is now merged

@tqchen tqchen merged commit c7b3ba5 into apache:master Apr 23, 2016
pluskid added a commit to dmlc/MXNet.jl that referenced this pull request Apr 23, 2016
@pluskid
Copy link
Contributor

pluskid commented Apr 23, 2016

Thanks! I fixed the Julia side.

@yzhliu
Copy link
Member

yzhliu commented Apr 25, 2016

@tqchen Shall we also modify the divide and subtract function in python/mxnet/ndarray.py, as I mentioned in tqchen#1 ?

@tqchen
Copy link
Member Author

tqchen commented Apr 25, 2016

@Javelinjs I changed the convention back, and changed the scala version as well.

@yzhliu
Copy link
Member

yzhliu commented Apr 25, 2016

Oh, I see.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants