-
Notifications
You must be signed in to change notification settings - Fork 6.8k
[OP] Move Elementwise binary scalar ops to SimpleOp Registry #1857
Conversation
This PR cause a backward compatible break in symbolic API.
I have updated the python API, but maybe changes in julia and scala is needed if you overloaded the operator. Since these symbols are not frequently used, I plan to merge this in when ok |
I'll fix it this weekend. |
@Javelinjs please do a PR to my repo so the things can be fixed when I merge this in. @thirdwing can you also do so for the R testcase? |
OK. I will do that tonight. |
@thirdwing @Javelinjs any update on this? |
[scala] operands change for SimpleOp Registry
Sorry for the late reply. Working on a conference paper. Will update this On Sun, Apr 17, 2016 at 1:49 AM, Tianqi Chen notifications@github.com
Qiang Kou |
I think it would be good to set a goal to introduce versioning into libmxnet. Then this kind of breaking changes will not be a disaster for other language bindings. |
agreed |
@thirdwing @pluskid @Javelinjs this is now merged |
Thanks! I fixed the Julia side. |
@Javelinjs I changed the convention back, and changed the scala version as well. |
Oh, I see. |
No description provided.