Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[Numpy][TVM] TVM reduce added, support initial value #16818

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

Laurawly
Copy link

@Laurawly Laurawly commented Nov 14, 2019

Description

Add support for initial parameter for reduce in TVMOp; also added support for min and max. Extended supported data types besides bool.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@Laurawly
Copy link
Author

Thanks helps from @yzhliu @haojin2 and @reminisce, could you review and comment?

@hgt312
Copy link
Contributor

hgt312 commented Nov 15, 2019

tvm.min is slightly different from np.min, because it do not handle NaN. Also max, maximum......

@haojin2 haojin2 requested review from haojin2 and reminisce and removed request for haojin2 November 16, 2019 23:46
@haojin2 haojin2 self-assigned this Nov 16, 2019
Ubuntu and others added 2 commits February 19, 2020 20:25
Committer: Leyuan Wang <laurawly@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants