This repository was archived by the owner on Nov 17, 2023. It is now read-only.
add AdaGrad optimizer in python, a revised version #1580
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
python/mxnet/optimizer.py
Outdated
| history = state | ||
| history[:] += (grad * grad) | ||
| delta = zeros(weight.shape, weight.context) | ||
| delta[:] = -self.lr * (grad / sqrt(history + self.float_stable_eps) + self.wd*weight) |
Member
There was a problem hiding this comment.
Can we directly use weight[:] += -self.lr * (grad / sqrt(history + self.float_stable_eps) + self.wd*weight) ?
Contributor
Author
There was a problem hiding this comment.
I have not tried but it should be correct.
Member
There was a problem hiding this comment.
Also, I think there should be a blank line after each member function and spaces for * OP.
Contributor
Author
|
Updated. |
Contributor
|
LGTM |
piiswrong
added a commit
that referenced
this pull request
Mar 9, 2016
add AdaGrad optimizer in python, a revised version
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@winstywang @sxjscience Sorry for my bad code. Thanks for commenting. This version is a revised version.