This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
fix LinearRegressionOutput with empty label #15620
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
||
|
||
int main() { | ||
std::cout << "Running regress label test" << std::endl; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could use
#include <dmlc/logging.h>
LOG(INFO) << "Running regress label test";
opReqMap, | ||
std::map<std::string, mxnet::cpp::NDArray>()); | ||
} catch (const std::exception& e) { | ||
std::cout << "Error while binding in mxnet: " << MXGetLastError() << std::endl; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above (at error level).
@mxnet-label-bot add [operator, backend] |
KellenSunderland
approved these changes
Jul 24, 2019
This was referenced Aug 7, 2019
TaoLv
pushed a commit
to TaoLv/incubator-mxnet
that referenced
this pull request
Aug 13, 2019
7 tasks
TaoLv
added a commit
that referenced
this pull request
Aug 14, 2019
anirudhacharya
pushed a commit
to anirudhacharya/mxnet
that referenced
this pull request
Aug 20, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is a behavior regression on LinearRegressionOutput after this CR: 3f3ba92#diff-726d19e2c39201681813130c8e2ac154
The previous CR changes the default TShape::ndim() to -1 instead of 0 but LinearRegressionOutput layer is not updated to handle new behavior of TShape.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes