This repository was archived by the owner on Nov 17, 2023. It is now read-only.
Minor fixes to documentation #13412
Merged
Minor fixes to documentation #13412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this change @piyushghai. Surrounding the classpath for java with quotes allows for users to run this on a wide variety of shells. The previous implementation without the quotes only works for bash. I have tested this on zsh, bash, sh, csh, tcsh, ksh. Running this command will prevent any errors for developers on these shells (and many more I presume). |
|
@mxnet-label-bot add [java, doc, pr-awaiting-review] |
harshp8l
approved these changes
Nov 27, 2018
|
Pom file changes LGTM |
harshp8l
approved these changes
Nov 27, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Small fixes to Java documentation.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
@lanking520 @andrewfayres