This repository was archived by the owner on Nov 17, 2023. It is now read-only.
Merged
Conversation
Member
|
can you fix the test case here? https://travis-ci.org/dmlc/mxnet/jobs/100461695 |
Author
|
The nosetests run on my computer, so I don't really know how to fix it. Do you have any insight? |
jmschrei
force-pushed
the
python_metrics
branch
3 times, most recently
from
6e9395e to
b1ec34e
Compare
Author
|
Looks like the lint check is still failing, but the python tests are passing now. |
Member
|
You can reproduce lint check locally via |
Author
|
32 python files fail the lint test locally. Is this expected? |
Member
|
Hmm, could due to pylint version so it behave differently. I guess we only need to fix the error reported by travis for now |
jmschrei
force-pushed
the
python_metrics
branch
from
b1ec34e to
69cf9f3
Compare
jmschrei
force-pushed
the
python_metrics
branch
from
69cf9f3 to
42dd1e4
Compare
Author
|
Looks like everything is finally massing @tqchen |
tqchen
added a commit
that referenced
this pull request
Jan 13, 2016
ENH python metrics added, fixed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python evaluation metrics have been updated. In addition to mean squared error and F1 being added, array size checks have been fixed for MAE and RMSE. All metrics can now be called using strings. More useful error messages have been added, and assertions have been replaced with a reused function. This solves issues #1163 and #1107.