-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Conversation
…ed_op (apache#10817)" (apache#11311)" This reverts commit e48a8fd.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please provide proof that #11171 is not the case in this PR and that the cache-hit-miss bug is covered as well
This is a different PR. If you have any specific concerns on the code please utter them. If you don't understand the code please let other people who do review it. |
Sorry if I mixed it up. I tried to read the description, but it was not very helpful. |
This reverts commit 5431e12.
@marcoabreu I have been intensively using CachedOp with static memory allocation this week. I also read the code in the past week. Other than the small bug reported previously, I don't find problems and it works very well with me in my PR. #10451 What are you looking for? If you are looking for test code, my entire PR can serve as test code. If you are looking for review, I have been reading the code for the entire week. I don't think it's reasonable to block other people's work for no reason. |
Hi Da, thanks for your comments. I'm sure that CachedOp is behaving as expected. The problems are described at #11318 |
I don't understand what the problem is. Because you veto, the PR should never be merged? We should open the PR and get proper reviews and merge it. Blocking other people to review it isn't a way of solving the problem. |
I was not the one who closed this PR, it was @tqchen. He was the one who dismissed my review and blocked other people from reviewing it. So why are you targeting this towards me? |
just to be fair, I dismissed the your comment with specific comment that addresses your issue https://github.com/apache/incubator-mxnet/pull/11313/files#diff-962bd5bb7248659d7eb3be37ee8a4c6bR1288 I agree that maybe more time should have been given to do the reviews, and I might be a bit aggressive, but never the less, vetoing things without understand what is going on seems to be not so constructive |
Thanks for the contribution, this is now merged
This reverts commit 5431e12.
* Revert "Revert "Static alloc for hybridblock (apache#11313)" (apache#11318)" This reverts commit 9b8eb56. * fix
Thanks for the contribution, this is now merged
This reverts commit 5431e12.
* Revert "Revert "Static alloc for hybridblock (apache#11313)" (apache#11318)" This reverts commit 9b8eb56. * fix
Description
(Brief description on what this PR is about)
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments