Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Static alloc for hybridblock #11313

Merged
merged 3 commits into from
Jun 16, 2018
Merged

Static alloc for hybridblock #11313

merged 3 commits into from
Jun 16, 2018

Conversation

piiswrong
Copy link
Contributor

Description

(Brief description on what this PR is about)

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@piiswrong piiswrong requested a review from szha as a code owner June 15, 2018 22:12
@tqchen tqchen self-requested a review June 15, 2018 22:16
Copy link
Contributor

@marcoabreu marcoabreu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide proof that #11171 is not the case in this PR and that the cache-hit-miss bug is covered as well

@piiswrong
Copy link
Contributor Author

piiswrong commented Jun 15, 2018

This is a different PR. If you have any specific concerns on the code please utter them.

If you don't understand the code please let other people who do review it.

@marcoabreu
Copy link
Contributor

Sorry if I mixed it up. I tried to read the description, but it was not very helpful.

@tqchen tqchen merged commit 5431e12 into apache:master Jun 16, 2018
marcoabreu added a commit that referenced this pull request Jun 16, 2018
marcoabreu added a commit that referenced this pull request Jun 16, 2018
tqchen added a commit that referenced this pull request Jun 16, 2018
@zheng-da
Copy link
Contributor

@marcoabreu I have been intensively using CachedOp with static memory allocation this week. I also read the code in the past week. Other than the small bug reported previously, I don't find problems and it works very well with me in my PR. #10451
I observe the memory allocation behavior and it works exactly as I expected.

What are you looking for? If you are looking for test code, my entire PR can serve as test code. If you are looking for review, I have been reading the code for the entire week. I don't think it's reasonable to block other people's work for no reason.

@marcoabreu
Copy link
Contributor

Hi Da, thanks for your comments. I'm sure that CachedOp is behaving as expected. The problems are described at #11318

@zheng-da
Copy link
Contributor

I don't understand what the problem is. Because you veto, the PR should never be merged?

We should open the PR and get proper reviews and merge it. Blocking other people to review it isn't a way of solving the problem.

@marcoabreu
Copy link
Contributor

I was not the one who closed this PR, it was @tqchen. He was the one who dismissed my review and blocked other people from reviewing it. So why are you targeting this towards me?

@tqchen
Copy link
Member

tqchen commented Jun 16, 2018

just to be fair, I dismissed the your comment with specific comment that addresses your issue https://github.com/apache/incubator-mxnet/pull/11313/files#diff-962bd5bb7248659d7eb3be37ee8a4c6bR1288

I agree that maybe more time should have been given to do the reviews, and I might be a bit aggressive, but never the less, vetoing things without understand what is going on seems to be not so constructive

piiswrong added a commit to piiswrong/mxnet that referenced this pull request Jun 16, 2018
piiswrong added a commit to piiswrong/mxnet that referenced this pull request Jun 18, 2018
piiswrong added a commit to piiswrong/mxnet that referenced this pull request Jun 19, 2018
piiswrong added a commit to piiswrong/mxnet that referenced this pull request Jun 19, 2018
marcoabreu pushed a commit that referenced this pull request Jun 20, 2018
* Revert "Revert "Static alloc for hybridblock (#11313)" (#11318)"

This reverts commit 9b8eb56.

* fix
zheng-da pushed a commit to zheng-da/incubator-mxnet that referenced this pull request Jun 28, 2018
Thanks for the contribution, this is now merged
zheng-da pushed a commit to zheng-da/incubator-mxnet that referenced this pull request Jun 28, 2018
zheng-da pushed a commit to zheng-da/incubator-mxnet that referenced this pull request Jun 28, 2018
* Revert "Revert "Static alloc for hybridblock (apache#11313)" (apache#11318)"

This reverts commit 9b8eb56.

* fix
XinYao1994 pushed a commit to XinYao1994/incubator-mxnet that referenced this pull request Aug 29, 2018
Thanks for the contribution, this is now merged
XinYao1994 pushed a commit to XinYao1994/incubator-mxnet that referenced this pull request Aug 29, 2018
XinYao1994 pushed a commit to XinYao1994/incubator-mxnet that referenced this pull request Aug 29, 2018
* Revert "Revert "Static alloc for hybridblock (apache#11313)" (apache#11318)"

This reverts commit 9b8eb56.

* fix
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants