This repository was archived by the owner on Nov 17, 2023. It is now read-only.
Improve data transform for gluon data loader #11183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piiswrong
suggested changes
Jun 8, 2018
| wsize = int(w * hsize / h) | ||
| else: | ||
| wsize, hsize = self._size | ||
| _args = tuple((wsize, hsize)) + (self._interpolation,) |
There was a problem hiding this comment.
image.imresize(x, wsize, hsize, self._interpolation)
| @@ -250,6 +250,9 @@ class Resize(Block): | |||
| ---------- | |||
| size : int or tuple of (W, H) | |||
| Size of output image. | |||
| keep_aspect_ratio : bool | |||
There was a problem hiding this comment.
keep_aspect_ratio feels too long
zheng-da
pushed a commit
to zheng-da/incubator-mxnet
that referenced
this pull request
Jun 28, 2018
* improve transforms.Resize * fix * Trigger CI * Trigger CI * improve * Trigger CI * Trigger CI * fix unittest * keep_ratio is false by default, to keep consistency
XinYao1994
pushed a commit
to XinYao1994/incubator-mxnet
that referenced
this pull request
Aug 29, 2018
* improve transforms.Resize * fix * Trigger CI * Trigger CI * improve * Trigger CI * Trigger CI * fix unittest * keep_ratio is false by default, to keep consistency
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
interpolationto 1, i.e. bilinear interpolation. The current value is 2 for cubic interpolation, which does not match the document.keep_aspect_ratiototransforms.Resize, so that its default behavior is to resize the short edge to the single input size value.Checklist