This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
fix shared_storage free #11159
Merged
fix shared_storage free #11159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szha
approved these changes
Jun 5, 2018
szha
reviewed
Jun 5, 2018
| @@ -215,12 +215,12 @@ void CPUSharedStorageManager::FreeImpl(const Storage::Handle& handle) { | |||
| << "Failed to unmap shared memory. munmap failed with error " | |||
| << strerror(errno); | |||
|
|
|||
| if (count == 0) { | |||
There was a problem hiding this comment.
the closing curly brace needs to be moved out of #ifdef __linux__ too
piiswrong
reviewed
Jun 5, 2018
| CHECK_EQ(close(handle.shared_id), 0) | ||
| << "Failed to close shared memory. close failed with error " | ||
| << strerror(errno); | ||
| CHECK_EQ(close(handle.shared_id), 0) |
There was a problem hiding this comment.
if(count==0) shouldnt' be moved. Skip close if shared_id == -1 instead
There was a problem hiding this comment.
You mean close on first FreeImpl and skip if already closed?
|
@piiswrong Can you have a second look? |
zheng-da
pushed a commit
to zheng-da/incubator-mxnet
that referenced
this pull request
Jun 28, 2018
* fix shared_storage free * fix bracket * make local ref * cpplint * fix tests * fix tests
XinYao1994
pushed a commit
to XinYao1994/incubator-mxnet
that referenced
this pull request
Aug 29, 2018
* fix shared_storage free * fix bracket * make local ref * cpplint * fix tests * fix tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix ndarray free on cpu_shared.
Original problem:
Using gluon.data.DataLoader with num_workers > 0 if ndarray was not originally on cpu_shared will cause
because file is already closed.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments