Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Update conv_layers.py documentation #11082

Merged
merged 3 commits into from
May 29, 2018
Merged

Conversation

ThomasDelteil
Copy link
Contributor

@ThomasDelteil ThomasDelteil commented May 28, 2018

Description

The output_padding parameter was missing from the doc string, wrong tuple size were used.
See: https://pytorch.org/docs/master/nn.html#convtranspose2d

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@ThomasDelteil ThomasDelteil requested a review from szha as a code owner May 28, 2018 20:39
@piiswrong piiswrong merged commit 9ab0d2b into apache:master May 29, 2018
@ThomasDelteil ThomasDelteil deleted the patch-23 branch May 31, 2018 16:00
rahul003 pushed a commit to rahul003/mxnet that referenced this pull request Jun 4, 2018
* Update conv_layers.py

* Update conv_layers.py

* Update conv_layers.py
zheng-da pushed a commit to zheng-da/incubator-mxnet that referenced this pull request Jun 28, 2018
* Update conv_layers.py

* Update conv_layers.py

* Update conv_layers.py
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants