Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

migrating docs build and publish job to secure nodes #11066

Merged
merged 1 commit into from
May 31, 2018
Merged

migrating docs build and publish job to secure nodes #11066

merged 1 commit into from
May 31, 2018

Conversation

aaronmarkham
Copy link
Contributor

@aaronmarkham aaronmarkham commented May 25, 2018 •
edited
Loading

Description

Migrating docs build to secure/restricted jenkins nodes.

  • Created a new jenkins job called restricted-website-publish
  • Updated nodes in Jenkinsfile node('restricted-mxnetlinux-cpu')
  • Updated Jenkinsfile to call new job restricted-website-publish

Comments

I would assume that the config in the Jenkins job for Restrict where this project can be run would be updated from mxnetlinux-cpu to restricted-mxnetlinux-cpu. However, I get an error if I try to do this:

There’s no agent/cloud that matches this assignment. Did you mean ‘mxnetlinux-cpu’ instead of ‘restricted-mxnetlinux-cpu’?

Once I get clarity on this, I can clone the build job and configure it to use the restricted naming.

@marcoabreu - what are your thoughts on this?

@aaronmarkham aaronmarkham requested a review from szha as a code owner May 25, 2018 20:27
@aaronmarkham
Copy link
Contributor Author

@marcoabreu - what's this what() failure on CI? I've seen it a couple of times. Something flakey?

@marcoabreu
Copy link
Contributor

Did you rename the Jenkins job to restricted-blabla?

The error that this slave does not exist is fine. It will automatically be deployed by auto scaling.

If the job does not picked up, you probably ran into a security measure that prevents accessing restricted nodes from unrestricted jobs or Vica versa. Let's review that on Monday

@marcoabreu
Copy link
Contributor

LGTM. Do you need any help?

@aaronmarkham
Copy link
Contributor Author

Yes, I'm getting a timeout which causes the job to fail (as cancelled).
http://jenkins.mxnet-ci.amazon-ml.com/job/restricted-website-build/3/console

@marcoabreu
Copy link
Contributor

Well you misconfigured the job ;) You assigned a restricted job to an unrestricted slave. I have corrected it for you

@marcoabreu
Copy link
Contributor

marcoabreu commented May 30, 2018 •
edited
Loading

Could you please also put the publish job into the Jenkinsfile structure - or maybe just combine both parts into one job?

@aaronmarkham
Copy link
Contributor Author

I wanted to get this first part working on the secure slaves. Then circle back with combining the job if I can manage to get the credentials part working.
So can we push this through as-is, now that you've fixed the publish job?

@marcoabreu marcoabreu merged commit d6f9cd8 into apache:master May 31, 2018
rahul003 pushed a commit to rahul003/mxnet that referenced this pull request Jun 4, 2018
@aaronmarkham @marcoabreu
migrating website build to secure nodes (apache#11066)
3e6067d
aaronmarkham added a commit to aaronmarkham/incubator-mxnet that referenced this pull request Jun 8, 2018
@aaronmarkham
migrating website build to secure nodes (apache#11066)
bf5623b
@aaronmarkham aaronmarkham mentioned this pull request Jun 8, 2018
Merged
marcoabreu pushed a commit that referenced this pull request Jun 11, 2018
@aaronmarkham @marcoabreu
docs build update for v1.2.1 (#11211)
73d3445 
* merged 10485

* clarify docs build (#10785)

* migrating website build to secure nodes (#11066)
zheng-da pushed a commit to zheng-da/incubator-mxnet that referenced this pull request Jun 28, 2018
@aaronmarkham @zheng-da
migrating website build to secure nodes (apache#11066)
c40ae59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@szha szha Awaiting requested review from szha szha is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aaronmarkham @marcoabreu