Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Fix DQN example #11051

Merged
merged 1 commit into from
May 30, 2018
Merged

Fix DQN example #11051

merged 1 commit into from
May 30, 2018

Conversation

larroy
Copy link
Contributor

@larroy larroy commented May 24, 2018

Description

Fixes for DQN RL rexample
setup.sh and fix visualization in dqn_run_test.py

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@larroy larroy requested a review from szha as a code owner May 24, 2018 14:43
@larroy larroy force-pushed the dqn branch 3 times, most recently from 6ce09bd to ebecee4 Compare May 24, 2018 14:47
fix type error: type of action needs to be int
@piiswrong piiswrong merged commit 005f677 into apache:master May 30, 2018
rahul003 pushed a commit to rahul003/mxnet that referenced this pull request Jun 4, 2018
fix type error: type of action needs to be int
@larroy larroy deleted the dqn branch June 17, 2018 02:04
zheng-da pushed a commit to zheng-da/incubator-mxnet that referenced this pull request Jun 28, 2018
fix type error: type of action needs to be int
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants