This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
[MXNET-399] Elemwise_mul between dense and csr on CPU & GPU #10894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haojin2
force-pushed
the
elemwise_mul_dns_csr
branch
from
98c3bd3 to
178173d
Compare
haojin2
force-pushed
the
elemwise_mul_dns_csr
branch
2 times, most recently
from
98b0d93 to
5e91b94
Compare
haojin2
changed the title
| CHECK_EQ(req, kWriteTo) << "elemwise(dns, csr) = csr only supports kWriteTo"; | ||
| CHECK(req != kNullOp); | ||
| const bool supported_op = std::is_same<OP, mshadow_op::mul>::value || | ||
| std::is_same<OP, mshadow_op::div>::value; |
| CHECK(req != kNullOp); | ||
| const bool supported_op = std::is_same<OP, mshadow_op::mul>::value || | ||
| std::is_same<OP, mshadow_op::div>::value; | ||
| CHECK(supported_op == true) << "elemwise(dns, csr) = csr only supports mul/div"; |
| CHECK_EQ(dns.storage_type(), kDefaultStorage); | ||
| CHECK_EQ(csr.storage_type(), kCSRStorage); | ||
| CHECK_EQ(req, kWriteTo) << "elemwise(dns, csr) = csr only supports kWriteTo"; | ||
| CHECK(req != kNullOp); |
There was a problem hiding this comment.
if (req == kNullOp) return
haojin2
force-pushed
the
elemwise_mul_dns_csr
branch
4 times, most recently
from
9a6e9cd to
72ed037
Compare
| CHECK_EQ(req, kWriteTo) << "elemwise(dns, csr) = csr only supports kWriteTo"; | ||
| if (req == kNullOp) return; | ||
| const bool supported_op = std::is_same<OP, mshadow_op::mul>::value; | ||
| CHECK(supported_op == true) << "elemwise(dns, csr) = csr only supports mul/div"; |
| const std::vector<NDArray> &outputs) { | ||
| const bool supported_ops = std::is_same<mshadow_op::right, LOP>::value && | ||
| std::is_same<mshadow_op::left, ROP>::value; | ||
| CHECK(supported_ops); |
haojin2
force-pushed
the
elemwise_mul_dns_csr
branch
from
72ed037 to
406210d
Compare
rahul003
pushed a commit
to rahul003/mxnet
that referenced
this pull request
Jun 4, 2018
…0894) * support elemwise_mul between dns and csr * address reviews and support for backward when ograd is dns
zheng-da
pushed a commit
to zheng-da/incubator-mxnet
that referenced
this pull request
Jun 28, 2018
…0894) * support elemwise_mul between dns and csr * address reviews and support for backward when ograd is dns
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As title
Checklist
Essentials
Changes
Comments