This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Fix row_sparse_pull with single gpu #10772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leezu
force-pushed
the
fixrowsparsepullsinglegpu
branch
from
47c26c2 to
52377b8
Compare
leezu
force-pushed
the
fixrowsparsepullsinglegpu
branch
from
52377b8 to
b507f78
Compare
leezu
force-pushed
the
fixrowsparsepullsinglegpu
branch
from
b507f78 to
c84d427
Compare
…mxnet into fixrowsparsepullsinglegpu
7 tasks
rahul003
approved these changes
May 2, 2018
rahul003
approved these changes
May 2, 2018
| @@ -91,6 +91,21 @@ def check_rsp_pull(kv, count, ctxs, is_same_rowid=False, use_slice=False): | |||
| check_rsp_push_pull('device') | |||
| check_rsp_push_pull('device', is_push_cpu=False) | |||
|
|
|||
|
|
|||
| def test_row_sparse_pull_single_device(): | |||
There was a problem hiding this comment.
The test is in kvstore gpu section but uses local kvstore and cpu context. It would probably make sense to change the test here to device and gpu?
There was a problem hiding this comment.
You're right. GPU was used previously in this test but these changes were accidentally pushed. Will update the test
anirudh2290
pushed a commit
to anirudh2290/mxnet
that referenced
this pull request
May 7, 2018
* Fix row_sparse_pull with single gpu * Add test * Fix row_sparse_pull with single gpu * Add test * fix sparse retain in comm.h * remove dedup var * update test
jinhuang415
pushed a commit
to jinhuang415/incubator-mxnet
that referenced
this pull request
May 29, 2018
* Fix row_sparse_pull with single gpu * Add test * Fix row_sparse_pull with single gpu * Add test * fix sparse retain in comm.h * remove dedup var * update test
rahul003
pushed a commit
to rahul003/mxnet
that referenced
this pull request
Jun 4, 2018
* Fix row_sparse_pull with single gpu * Add test * Fix row_sparse_pull with single gpu * Add test * fix sparse retain in comm.h * remove dedup var * update test
zheng-da
pushed a commit
to zheng-da/incubator-mxnet
that referenced
this pull request
Jun 28, 2018
* Fix row_sparse_pull with single gpu * Add test * Fix row_sparse_pull with single gpu * Add test * fix sparse retain in comm.h * remove dedup var * update test
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using the kvstore on a single device, no copy of the source array would be created when pushing to the kvstore. When row sparse pulling from the kvstore, this would lead to a deadlock as both source and target arrays were identical. For now this PR removes the optimization of not creating a copy.
Thanks @eric-haibin-lin for helping to find the cause.