This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Add cuda version check to skip building quantization ops for versions less than 8.0 #10710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please note this change is not verifiable by CI since we only support CUDA>=8.0. Please validate it manually |
reminisce
force-pushed
the
add_cuda_version_check_for_quantization
branch
from
c439b7b to
c666eae
Compare
reminisce
changed the title
|
@marcoabreu I launched a Ubuntu 14.04 instance and installed cuda-7.5 and cudnn-6. The build can pass successfully with this PR. Unit tests other than quantization_gpu can pass as well which is as expected. Please help to review: @szha @piiswrong @anirudh2290 |
anirudh2290
reviewed
Apr 27, 2018
| @@ -270,7 +270,7 @@ void QuantizedConvForwardGPU(const nnvm::NodeAttrs& attrs, | |||
| const ConvolutionParam& param = nnvm::get<ConvolutionParam>(attrs.parsed); | |||
| CHECK_EQ(param.kernel.ndim(), 2U) | |||
| << "QuantizedConvForward<gpu> only supports 2D convolution for now"; | |||
| #if MXNET_USE_CUDNN == 1 && CUDNN_MAJOR >= 6 | |||
| #if MXNET_USE_CUDNN == 1 && CUDNN_MAJOR >= 6 && CUDA_VERSION >= 8000 | |||
There was a problem hiding this comment.
Does this need to have an else clause? What is the expected behavior if quantizedpoolforwadgpu is called with cuda version < 8 ?
There was a problem hiding this comment.
There will be an error message printed saying that otherwise is not supported. I have made it clearer on specifying cudnn and cuda versions.
reminisce
force-pushed
the
add_cuda_version_check_for_quantization
branch
from
82c1da3 to
363de1e
Compare
anirudh2290
approved these changes
Apr 29, 2018
anirudh2290
pushed a commit
to anirudh2290/mxnet
that referenced
this pull request
Apr 29, 2018
… less than 8.0 (apache#10710) * Add cuda version check to skip building quantization ops for version less 8 * Clearer error message on cuda and cudnn versions * Trigger CI
anirudh2290
pushed a commit
to anirudh2290/mxnet
that referenced
this pull request
Apr 29, 2018
anirudh2290
pushed a commit
to anirudh2290/mxnet
that referenced
this pull request
Apr 30, 2018
piiswrong
pushed a commit
that referenced
this pull request
Apr 30, 2018
anirudh2290
pushed a commit
to anirudh2290/mxnet
that referenced
this pull request
May 7, 2018
… less than 8.0 (apache#10710) * Add cuda version check to skip building quantization ops for version less 8 * Clearer error message on cuda and cudnn versions * Trigger CI
rahul003
pushed a commit
to rahul003/mxnet
that referenced
this pull request
Jun 4, 2018
… less than 8.0 (apache#10710) * Add cuda version check to skip building quantization ops for version less 8 * Clearer error message on cuda and cudnn versions * Trigger CI
zheng-da
pushed a commit
to zheng-da/incubator-mxnet
that referenced
this pull request
Jun 28, 2018
… less than 8.0 (apache#10710) * Add cuda version check to skip building quantization ops for version less 8 * Clearer error message on cuda and cudnn versions * Trigger CI
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Build would fail if users installed cuda prior to version 8.0. Added cuda version check to prevent build failure.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments