Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[MXNET-357][WIP] New Scala API Design (NDArray) #10707

Merged
merged 1 commit into from
May 1, 2018

Conversation

lanking520
Copy link
Member

@lanking520 lanking520 commented Apr 26, 2018

Description

See full design document
@nswamy @yzhliu
This PR is the Addition for new NDArray functions of Scala API

Checklist

Essentials

  • Use QuasiQuote to replace original API Implementation (Reduce lines)
  • MakeAtomicFunction change to support String type parameter type in
  • User New namespace for New API (temporarily New)
  • Default args using None to pass in as default
  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@lanking520 lanking520 requested a review from yzhliu as a code owner April 26, 2018 21:50
@lanking520 lanking520 changed the title [MXNET-357] New Scala API Design (NDArray) [MXNET-357][WIP] New Scala API Design (NDArray) Apr 26, 2018
@yzhliu yzhliu merged commit 1ab0733 into apache:master May 1, 2018
anirudh2290 pushed a commit to anirudh2290/mxnet that referenced this pull request May 7, 2018
rahul003 pushed a commit to rahul003/mxnet that referenced this pull request Jun 4, 2018
zheng-da pushed a commit to zheng-da/incubator-mxnet that referenced this pull request Jun 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants