This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
[MXNET-347] Logical Operators AND, XOR, OR #10679
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
haojin2
reviewed
Apr 25, 2018
haojin2
reviewed
Apr 25, 2018
haojin2
reviewed
Apr 25, 2018
haojin2
reviewed
Apr 25, 2018
haojin2
reviewed
Apr 25, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some nits
anirudhacharya
force-pushed
the
opsLogical
branch
from
April 25, 2018 18:05
91af768
to
7b30d5a
Compare
anirudhacharya
force-pushed
the
opsLogical
branch
from
April 25, 2018 18:10
7b30d5a
to
266a134
Compare
cjolivier01
reviewed
Apr 25, 2018
haojin2
reviewed
Apr 25, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comment
@piiswrong @cjolivier01 could please take a look. I have addressed your comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eric-haibin-lin should I update these under |
eric-haibin-lin
approved these changes
May 1, 2018
anirudh2290
pushed a commit
to anirudh2290/mxnet
that referenced
this pull request
May 7, 2018
* logical and * logical OR and XOR operators. * better examples * nits. * elemwise operators * non broadcast examples and tests. * doc API * rerun CI
rahul003
pushed a commit
to rahul003/mxnet
that referenced
this pull request
Jun 4, 2018
* logical and * logical OR and XOR operators. * better examples * nits. * elemwise operators * non broadcast examples and tests. * doc API * rerun CI
zheng-da
pushed a commit
to zheng-da/incubator-mxnet
that referenced
this pull request
Jun 28, 2018
* logical and * logical OR and XOR operators. * better examples * nits. * elemwise operators * non broadcast examples and tests. * doc API * rerun CI
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds Logical AND, XOR, OR operator.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments