Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[MXNET-347] Logical Operators AND, XOR, OR #10679

Merged
merged 8 commits into from
May 1, 2018

Conversation

anirudhacharya
Copy link
Member

@anirudhacharya anirudhacharya commented Apr 25, 2018

Description

Adds Logical AND, XOR, OR operator.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • AND, OR, XOR operator.

Comments

Copy link
Contributor

@haojin2 haojin2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some nits

src/operator/mshadow_op.h Show resolved Hide resolved
tests/python/unittest/test_operator.py Outdated Show resolved Hide resolved
Copy link
Contributor

@haojin2 haojin2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment

@anirudhacharya anirudhacharya requested a review from szha as a code owner April 28, 2018 01:37
@anirudhacharya
Copy link
Member Author

@piiswrong @cjolivier01 could please take a look. I have addressed your comments.

@eric-haibin-lin eric-haibin-lin self-assigned this Apr 30, 2018
Copy link
Member

@eric-haibin-lin eric-haibin-lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anirudhacharya
Copy link
Member Author

@eric-haibin-lin should I update these under Comparison or should I create a new Logical category? I think even this - #10639 needs to be updated in the doc API.

@eric-haibin-lin eric-haibin-lin merged commit 61f86fc into apache:master May 1, 2018
@anirudhacharya anirudhacharya deleted the opsLogical branch May 1, 2018 22:42
anirudh2290 pushed a commit to anirudh2290/mxnet that referenced this pull request May 7, 2018
* logical and

* logical OR and XOR operators.

* better examples

* nits.

* elemwise operators

* non broadcast examples and tests.

* doc API

* rerun CI
rahul003 pushed a commit to rahul003/mxnet that referenced this pull request Jun 4, 2018
* logical and

* logical OR and XOR operators.

* better examples

* nits.

* elemwise operators

* non broadcast examples and tests.

* doc API

* rerun CI
zheng-da pushed a commit to zheng-da/incubator-mxnet that referenced this pull request Jun 28, 2018
* logical and

* logical OR and XOR operators.

* better examples

* nits.

* elemwise operators

* non broadcast examples and tests.

* doc API

* rerun CI
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants