Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[MXNET-358] support dense weight & sparse grad for adam, sgd and sgd_momentum #10664

Merged
merged 6 commits into from
May 1, 2018

Conversation

eric-haibin-lin
Copy link
Member

Description

(Brief description on what this PR is about)

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@eric-haibin-lin eric-haibin-lin requested a review from szha as a code owner April 24, 2018 00:43
@eric-haibin-lin eric-haibin-lin changed the title [MXNET-358] [WIP] support dense weight & sparse grad for adam, sgd and sgd_momentum [MXNET-358] support dense weight & sparse grad for adam, sgd and sgd_momentum Apr 30, 2018
@eric-haibin-lin
Copy link
Member Author

@haojin2 @ZiyueHuang

SGDMomStdUpdateRspImpl<xpu>(param, ctx, weight, grad, mom, req[0], &out);
}
} else if (w_stype == kRowSparseStorage && valid_grad && m_stype == kDefaultStorage) {
// rsp weight, rsp grad, dns state -> std update
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we check lazy_update = false here? Since standard update is applied here if rsp weight, rsp grad, dns state.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually even if lazy_update=True we will apply standard update in this case to keep backward compatibility. In the doc:

However, if grad's storage type is ``row_sparse``, ``lazy_update`` is True and weight's storage
type is the same as momentum's storage type,
 only the row slices whose indices appear in grad.indices are updated (for both weight and momentum)::

@eric-haibin-lin eric-haibin-lin merged commit 9f8f042 into apache:master May 1, 2018
anirudh2290 pushed a commit to anirudh2290/mxnet that referenced this pull request May 7, 2018
…momentum (apache#10664)

* + support for dense weight with sparse grad for adam & sgd
mom

* fix test

* sgd passes

* fix typo

* support adam

* update doc
rahul003 pushed a commit to rahul003/mxnet that referenced this pull request Jun 4, 2018
…momentum (apache#10664)

* + support for dense weight with sparse grad for adam & sgd
mom

* fix test

* sgd passes

* fix typo

* support adam

* update doc
zheng-da pushed a commit to zheng-da/incubator-mxnet that referenced this pull request Jun 28, 2018
…momentum (apache#10664)

* + support for dense weight with sparse grad for adam & sgd
mom

* fix test

* sgd passes

* fix typo

* support adam

* update doc
@eric-haibin-lin eric-haibin-lin deleted the optim branch September 18, 2018 23:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants