This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
[MXNET-358] support dense weight & sparse grad for adam, sgd and sgd_momentum #10664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-haibin-lin
changed the title
[MXNET-358] [WIP] support dense weight & sparse grad for adam, sgd and sgd_momentum
[MXNET-358] support dense weight & sparse grad for adam, sgd and sgd_momentum
Apr 30, 2018
ZiyueHuang
reviewed
Apr 30, 2018
SGDMomStdUpdateRspImpl<xpu>(param, ctx, weight, grad, mom, req[0], &out); | ||
} | ||
} else if (w_stype == kRowSparseStorage && valid_grad && m_stype == kDefaultStorage) { | ||
// rsp weight, rsp grad, dns state -> std update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we check lazy_update = false
here? Since standard update is applied here if rsp weight, rsp grad, dns state
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually even if lazy_update=True we will apply standard update in this case to keep backward compatibility. In the doc:
However, if grad's storage type is ``row_sparse``, ``lazy_update`` is True and weight's storage
type is the same as momentum's storage type,
only the row slices whose indices appear in grad.indices are updated (for both weight and momentum)::
ZiyueHuang
approved these changes
May 1, 2018
anirudh2290
pushed a commit
to anirudh2290/mxnet
that referenced
this pull request
May 7, 2018
…momentum (apache#10664) * + support for dense weight with sparse grad for adam & sgd mom * fix test * sgd passes * fix typo * support adam * update doc
rahul003
pushed a commit
to rahul003/mxnet
that referenced
this pull request
Jun 4, 2018
…momentum (apache#10664) * + support for dense weight with sparse grad for adam & sgd mom * fix test * sgd passes * fix typo * support adam * update doc
zheng-da
pushed a commit
to zheng-da/incubator-mxnet
that referenced
this pull request
Jun 28, 2018
…momentum (apache#10664) * + support for dense weight with sparse grad for adam & sgd mom * fix test * sgd passes * fix typo * support adam * update doc
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
(Brief description on what this PR is about)
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments