This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
[MXNET-356] Fix for the search results issues #10656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sion (if it exists) to add it as a part of the URL given in the search results drop-down. Next, in the search results page corrected the search preview target page from txt to html
|
Hi @kpmurali - the preview doesn't have the different versions, so I'm unable to validate the fix for the first issue. Using the manual approach, I pulled the URL that was generated in the search result and pasted it into a production setting. It doesn't seem to have the right URL. |
|
@eric-haibin-lin can you please merge this? |
zheng-da
pushed a commit
to zheng-da/incubator-mxnet
that referenced
this pull request
Jun 28, 2018
* Fix for the search results issues. This changes reads the current version (if it exists) to add it as a part of the URL given in the search results drop-down. Next, in the search results page corrected the search preview target page from txt to html * Changing the AJAX type from html back to txt * Fixing the broken changes in the searchtools js
XinYao1994
pushed a commit
to XinYao1994/incubator-mxnet
that referenced
this pull request
Aug 29, 2018
* Fix for the search results issues. This changes reads the current version (if it exists) to add it as a part of the URL given in the search results drop-down. Next, in the search results page corrected the search preview target page from txt to html * Changing the AJAX type from html back to txt * Fixing the broken changes in the searchtools js
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There are two issues with the MXNet search result lists: first, when accessed as the drop-down for an earlier version, the URL in the drop-down redirects to the corresponding page in the default version. Second, in the search results after pressing enter, there are entries with HTTP 404 error.
Changes
Preview - http://54.210.6.225/