Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[MXNET-311] Change the docker image for Installation Guide Test - needs sudo #10510

Merged
merged 1 commit into from
Apr 12, 2018
Merged

[MXNET-311] Change the docker image for Installation Guide Test - needs sudo #10510

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions tests/jenkins/run_test_installation_docs.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,17 +298,20 @@ LINUX_PYTHON_GPU_END_LINENO=$(grep -n "END - Linux Python GPU Installation Instr

set_instruction_set ${LINUX_PYTHON_GPU_START_LINENO} ${LINUX_PYTHON_GPU_END_LINENO}


# mxnet/base-cuda9 is a simple Docker Image with 'nvidia/cuda:9.0-cudnn7-devel' and 'apt-get install sudo'.

echo
echo "### Testing Virtualenv ###"
echo "${virtualenv_commands}"
echo
nvidia-docker run --rm nvidia/cuda:9.0-cudnn7-devel bash -c "${virtualenv_commands}"
nvidia-docker run --rm mxnet/base-cuda9 bash -c "${virtualenv_commands}"
Copy link
Member

@anirudh2290 anirudh2290 Apr 11, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be more maintainable if we push this docker image for nightly tests to the docker registry (maybe with a different name as @gautamkmr suggested). The release doesn't have to block on this though.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where can I see the contents of this image? Also it would be good to keep consistency with nvidia images (I assume they are taken as base anyway) and name and branch them with minor versions of cuda: mxnet/base:cuda9.0 mxnet/base:cuda9.1


echo
echo "### Testing Pip ###"
echo "${pip_commands}"
echo
nvidia-docker run --rm nvidia/cuda:9.0-cudnn7-devel bash -c "${pip_commands}"
nvidia-docker run --rm mxnet/base-cuda9 bash -c "${pip_commands}"

echo
echo "### Testing Docker ###"
Expand All @@ -320,4 +323,4 @@ echo
echo "### Testing Build From Source ###"
echo "${buildfromsource_commands}"
echo
nvidia-docker run --rm nvidia/cuda:9.0-cudnn7-devel bash -c "${buildfromsource_commands}"
nvidia-docker run --rm mxnet/base-cuda9 bash -c "${buildfromsource_commands}"