Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[MXNET-308] [Perl] added missing license #10497

Merged
merged 1 commit into from
Apr 11, 2018

Conversation

sergeykolychev
Copy link
Contributor

@sergeykolychev sergeykolychev commented Apr 11, 2018

Description

(Brief description on what this PR is about)

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@sergeykolychev
Copy link
Contributor Author

@eric-haibin-lin @mbaijal @anirudh2290
I've added missing license to four files from the list.
Other 9 are Changes, MANIFEST and META.yml (for 3 modules that comprise the perl-package) are autogenerated files that perl modules aggregator CPAN uses for indexing purposes and can't have comments in them.
Changes - list of changes to the module
MANIFEST - list of files in the module
META.yml - meta information about the module (version, external dependencies, etc).
I'd like to request kindly add these to the list of excepted files.

@mbaijal
Copy link
Contributor

mbaijal commented Apr 11, 2018

@sergeykolychev
Sergey, Thanks for updating the licenses.
you just need to add the names of the file to the .rat-excludes file here - https://github.com/apache/incubator-mxnet/blob/master/tests/nightly/apache_rat_license_check/.rat-excludes

However, this file does not accept full file paths for some reason and only the name of the file. Hence to avoid excluding all files with the same name, I had added the whole perl-package to this excluded list. You can handle this in any way you want.

@anirudh2290 Do make sure RAT check passes after these changes are included!

@anirudh2290
Copy link
Member

@mbaijal sounds like the only option we have right now is to add the names Changes, Manifest and META.yml to .rat-excludes and hope that we remember to check the licenses if the same named files are used elsewhere in MXNet (I checked that currently the file names are being used only inside perl-package).

@eric-haibin-lin
Copy link
Member

Thank you @sergeykolychev !

@eric-haibin-lin eric-haibin-lin merged commit 56649e6 into apache:master Apr 11, 2018
@eric-haibin-lin eric-haibin-lin changed the title MXNET-308 [Perl] added missing license [MXNET-308] [Perl] added missing license Apr 11, 2018
dabraude pushed a commit to dabraude/incubator-mxnet that referenced this pull request Apr 12, 2018
rahul003 pushed a commit to rahul003/mxnet that referenced this pull request Jun 4, 2018
zheng-da pushed a commit to zheng-da/incubator-mxnet that referenced this pull request Jun 28, 2018
piiswrong pushed a commit that referenced this pull request Jun 28, 2018
* Remove Fermi from cmake (#10486)

* updated R docs (#10473)

* [MXNET-120] Float16 support for distributed training (#10183)

* send as char

* fix bug on pull response, and rowsparse on worker side

* three modes

* default to mode 0 and add support for row sparse

* refactor sparse

* rowsparse numbytes fixes

* WIP tests

* update test sync

* remove prints

* refactoring

* Revert "refactoring"

This reverts commit 05ffa1b.

* undo refactoring to keep PR simple

* add wait to stored in pull default

* lint fixes

* undo static cast for recvblob

* lint fixes

* mode 1 changes

* sparse bug fix dtype

* mshadow default

* remove unused var

* remove debug statements

* clearer variables, reduced multiplication, const vars

* add const for more vars, comments

* comment syntax, code watcher, test default val

* remove unnecessary print in test

* trigger ci

* multi precision mode (debugging race condition)

* working rsp pushes

* finish multiprecision for row sparse

* rename num-bytes

* fix bug due to rename of numbytes, and remove debug logs

* address comments

* add integration test

* trigger ci

* integration test

* integration test

* fix path of script

* update mshadow

* disable f16c for amalgamation

* fix amalgamation build

* trigger ci

* disable f16c for jetson

* Fix rat excludes (#10499)

* MXNET-308 added missing license (#10497)

* refactored example (#10484)

* [MXNET-298] Scala Infer API docs landing page (#10474)

* changed url references from dmlc to apache/incubator-mxnet

* prepping scala landing pages

* infer api info added

* Fix infer storage type (#10507)

* Fix infer_storage_type

* Add test

* Fix lint

* Trigger CI

* [MXNET-306] Add slice_like operator (#10491)

* add slice_like and doc

* pass unittest and lint

* Minor simplifications in ci/build.py (#10496)

* [MXNET-305] Scala tutorial table fix (#10488)

* initial update on setting up scala ide with mxnet

* moving images to web-data project

* updated links to images; added readme for root folder

* scala hello world feature added

* workaround for make transitive error

* fixed systempath

* minor updates

* table fix

* added some spacing

* more spacing

* added ability to set search path for Accelerate library

* [MXNET-311] change test needs a docker with sudo, hence image changed (#10510)

* added new metric

* changed back from branch to upstream

* lint changed

* Fixed typo

* Clarified interpretation

* Changes for variable names

* fixed variable names

* replay the unit tests

* changed comment
XinYao1994 pushed a commit to XinYao1994/incubator-mxnet that referenced this pull request Aug 29, 2018
…e#10524)

* Remove Fermi from cmake (apache#10486)

* updated R docs (apache#10473)

* [MXNET-120] Float16 support for distributed training (apache#10183)

* send as char

* fix bug on pull response, and rowsparse on worker side

* three modes

* default to mode 0 and add support for row sparse

* refactor sparse

* rowsparse numbytes fixes

* WIP tests

* update test sync

* remove prints

* refactoring

* Revert "refactoring"

This reverts commit 05ffa1b.

* undo refactoring to keep PR simple

* add wait to stored in pull default

* lint fixes

* undo static cast for recvblob

* lint fixes

* mode 1 changes

* sparse bug fix dtype

* mshadow default

* remove unused var

* remove debug statements

* clearer variables, reduced multiplication, const vars

* add const for more vars, comments

* comment syntax, code watcher, test default val

* remove unnecessary print in test

* trigger ci

* multi precision mode (debugging race condition)

* working rsp pushes

* finish multiprecision for row sparse

* rename num-bytes

* fix bug due to rename of numbytes, and remove debug logs

* address comments

* add integration test

* trigger ci

* integration test

* integration test

* fix path of script

* update mshadow

* disable f16c for amalgamation

* fix amalgamation build

* trigger ci

* disable f16c for jetson

* Fix rat excludes (apache#10499)

* MXNET-308 added missing license (apache#10497)

* refactored example (apache#10484)

* [MXNET-298] Scala Infer API docs landing page (apache#10474)

* changed url references from dmlc to apache/incubator-mxnet

* prepping scala landing pages

* infer api info added

* Fix infer storage type (apache#10507)

* Fix infer_storage_type

* Add test

* Fix lint

* Trigger CI

* [MXNET-306] Add slice_like operator (apache#10491)

* add slice_like and doc

* pass unittest and lint

* Minor simplifications in ci/build.py (apache#10496)

* [MXNET-305] Scala tutorial table fix (apache#10488)

* initial update on setting up scala ide with mxnet

* moving images to web-data project

* updated links to images; added readme for root folder

* scala hello world feature added

* workaround for make transitive error

* fixed systempath

* minor updates

* table fix

* added some spacing

* more spacing

* added ability to set search path for Accelerate library

* [MXNET-311] change test needs a docker with sudo, hence image changed (apache#10510)

* added new metric

* changed back from branch to upstream

* lint changed

* Fixed typo

* Clarified interpretation

* Changes for variable names

* fixed variable names

* replay the unit tests

* changed comment
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants