Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

Conversation

kpmurali
Copy link
Contributor

@kpmurali kpmurali commented Apr 10, 2018

Description

Adding a download page with Apache mirror source links.

Changes

  • [ x ] Adding a download page on the mxnet website.
  • [ x ] Download point to our mirror system, not gihtub managed links. ß--- ASF mirror

http://54.210.6.225/install/download.html #

@kpmurali kpmurali requested a review from szha as a code owner April 10, 2018 02:48
@marcoabreu
Copy link
Contributor

marcoabreu commented Apr 10, 2018

Hi @kpmurali, thanks for addressing the mentors comments.

Just to clarify, these are source downloads, right? I think it would be a bit misleading to our users to classify this as just "Download" without any further information. At any point in time, I'd prefer our users to see the binary release as the first option besides the download of a source release - otherwise people might get a bit lost.

Also, the link is a bit hidden and only reachable if you click on 'Download' on the install index page. I don't think this is consistent with the other page we have.

@aaronmarkham wdyt?

@kpmurali
Copy link
Contributor Author

Hi @marcoabreu , yes these are links to the source downloads. @aaronmarkham, any suggestions on where else the link to the Download page can be placed?


Choose your flavor of download from the following links:
These source archives are generated from tagged releases. Updates and patches will not have been applied. For any updates refer to the corresponding branches in the GitHub repository. Choose your flavor of download from the following links:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe make "GitHub repository" a link?

<br/>
<!-- Download -->

# Source Download
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aaronmarkham the git clone section always clones the bleeding edge master. Should we move this "Source Download" to step 4 instead?

@anirudh2290
Copy link
Member

@eric-haibin-lin can we merge this ?

@eric-haibin-lin eric-haibin-lin merged commit 210e6d4 into apache:master Apr 17, 2018
anirudh2290 pushed a commit to anirudh2290/mxnet that referenced this pull request Apr 17, 2018
…ge (apache#10477)

* Adding the Download page and linking it to the Install page

* Removing the extra 'Download Source Package' section header

* Minor fixes to the download page and the reference to it

* Adding the GitHub repository link to the download page content

* Minor text fix in install/index

* Adding the download page in Step 4 for install
eric-haibin-lin pushed a commit that referenced this pull request Apr 17, 2018
…ge (#10477)

* Adding the Download page and linking it to the Install page

* Removing the extra 'Download Source Package' section header

* Minor fixes to the download page and the reference to it

* Adding the GitHub repository link to the download page content

* Minor text fix in install/index

* Adding the download page in Step 4 for install
rahul003 pushed a commit to rahul003/mxnet that referenced this pull request Jun 4, 2018
…ge (apache#10477)

* Adding the Download page and linking it to the Install page

* Removing the extra 'Download Source Package' section header

* Minor fixes to the download page and the reference to it

* Adding the GitHub repository link to the download page content

* Minor text fix in install/index

* Adding the download page in Step 4 for install
zheng-da pushed a commit to zheng-da/incubator-mxnet that referenced this pull request Jun 28, 2018
…ge (apache#10477)

* Adding the Download page and linking it to the Install page

* Removing the extra 'Download Source Package' section header

* Minor fixes to the download page and the reference to it

* Adding the GitHub repository link to the download page content

* Minor text fix in install/index

* Adding the download page in Step 4 for install
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants