Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[MXNET-260]remove use_fast_math #10364

Merged
merged 1 commit into from
Apr 3, 2018
Merged

Conversation

yajiedesign
Copy link
Contributor

@yajiedesign yajiedesign commented Apr 2, 2018

Description

remove use_fast_math because it causes some operations to appear Nan

https://issues.apache.org/jira/browse/MXNET-260

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:

Changes

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@sxjscience
Copy link
Member

This solves #9572 . Also, I find that (-1)**2 and (-1)**3 are not tested in the code. We'd better test these cases here (https://github.com/apache/incubator-mxnet/blob/master/tests/python/unittest/test_operator.py#L431-L438).

@piiswrong
Copy link
Contributor

Also need to turn it off for Makefile?

@szha
Copy link
Member

szha commented Apr 2, 2018

Makefile doesn't have that flag for nvcc compilation lines. It doesn't seem like the cmake development includes the consistency of compilation flags as part of the requirement.

@piiswrong piiswrong merged commit 47d0b58 into apache:master Apr 3, 2018
rahul003 pushed a commit to rahul003/mxnet that referenced this pull request Jun 4, 2018
zheng-da pushed a commit to zheng-da/incubator-mxnet that referenced this pull request Jun 28, 2018
@yajiedesign yajiedesign deleted the addcmake2 branch October 31, 2018 21:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants