This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
[MXNET-250] CSS and .htaccess fix #10286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
March 27, 2018 05:04
|
We need to have the package links in there, but this will be handled with a subsequent PR. |
| @@ -68,6 +68,7 @@ for tag in $tag_list; do | |||
| git checkout master -- docs/mxdoc.py | |||
| fi | |||
| git submodule update || exit 1 | |||
| git submodule update --init --recursive | |||
There was a problem hiding this comment.
I have tried updating it together, but its unstable. I have found this to be better and working consistently
| # During a nightly build, these fixes will be patched to all the versions in the asf-site repository including the master folder under versions directory. | ||
| # copy <master folder location> <version folder location> | ||
|
|
||
| #SIM: https://sim.amazon.com/issues/AWSDBUX-19727 |
There was a problem hiding this comment.
I don't think we should put public unaccessible link here
| python AddPackageLink.py --file_path "$built/versions/master/install/index.html" \ | ||
| --current_version "$tag" || exit 1 | ||
| fi | ||
| #if [ $tag != 'master' ] |
rahul003
pushed a commit
to rahul003/mxnet
that referenced
this pull request
Jun 4, 2018
* css_and_install_fixes * fixed the broken installation page * copy install index.html fix to 1.1.0 and master versions * fixed install.md * fixed variable definition and install copy logic * added .htaccess and updated .htaccess copy to root folder * copy .htaccess to root folder * updated update_all_version.sh * fixed renaming of the function call * reverted back AddVersion.py from master * removed duplicate master being appended * commented out AddPackageLink.py to fix the master install page issue * removed commented out lines and not required
zheng-da
pushed a commit
to zheng-da/incubator-mxnet
that referenced
this pull request
Jun 28, 2018
* css_and_install_fixes * fixed the broken installation page * copy install index.html fix to 1.1.0 and master versions * fixed install.md * fixed variable definition and install copy logic * added .htaccess and updated .htaccess copy to root folder * copy .htaccess to root folder * updated update_all_version.sh * fixed renaming of the function call * reverted back AddVersion.py from master * removed duplicate master being appended * commented out AddPackageLink.py to fix the master install page issue * removed commented out lines and not required
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[ ] Copy .htaccess from master to root folder.
[ ] Copy CSS fix (mxnet.css) into all the versions.
[ ] Test out link - http://34.207.78.24/