Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Fix failed test with opencv 3.4.1 #10197

Merged
merged 3 commits into from
Mar 23, 2018
Merged

Conversation

asitstands
Copy link
Contributor

Description

Fix a test which causes an error with opencv 3.4.1. I'm not sure which version of opencv is used in mxnet's testing environment but the test_resize_short in test_image.py causes the following error on my Arch linux system with opencv 3.4.1 and python 3.6.4.

======================================================================
ERROR: test_resize_short (test_image.TestImage)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/pds/pds131/asitdepends/Tmp/mxnet/incubator-mxnet/tests/python/unittest/test_image.py", line 118, in test_resize_short
    cv_resized = cv2.resize(cv_img, (new_w, new_h), interpolation=interp)
TypeError: integer argument expected, got float
----------------------------------------------------------------------

This PR fixes it.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@@ -110,9 +110,9 @@ def test_resize_short(self):
for _ in range(3):
new_size = np.random.randint(1, 1000)
if h > w:
new_h, new_w = new_size * h / w, new_size
new_h, new_w = int(new_size * h / w), new_size
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The float number comes from the division, which in python3 is float division by default. You can just replace / with // to fix.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks more clear and resonable. I updated.

@piiswrong piiswrong merged commit ce2ce9b into apache:master Mar 23, 2018
ashokei pushed a commit to ashokei/incubator-mxnet that referenced this pull request Mar 27, 2018
* Fix failed test with opencv 3.4.1

* Replace int conversion with `//`

* retrigger test
@asitstands asitstands deleted the unittest_image branch March 28, 2018 04:39
jinhuang415 pushed a commit to jinhuang415/incubator-mxnet that referenced this pull request Mar 30, 2018
* Fix failed test with opencv 3.4.1

* Replace int conversion with `//`

* retrigger test
rahul003 pushed a commit to rahul003/mxnet that referenced this pull request Jun 4, 2018
* Fix failed test with opencv 3.4.1

* Replace int conversion with `//`

* retrigger test
zheng-da pushed a commit to zheng-da/incubator-mxnet that referenced this pull request Jun 28, 2018
* Fix failed test with opencv 3.4.1

* Replace int conversion with `//`

* retrigger test
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants