-
Notifications
You must be signed in to change notification settings - Fork 6.8k
generate Scala documentation for infer package #10181
Conversation
LGTM! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this run as part of CI?
# scaldoc fails on some apis, so exit 0 to pass the check | ||
_run_cmd('cd ' + scala_path + '; scaladoc `find . | grep .*scala`; exit 0') | ||
_run_cmd('cd ' + scala_path + '; scaladoc `find . -type f -name "*.scala" | egrep \"\/core|\/infer\" | egrep -v \"Suite\"`; exit 0') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you own this so I’m no adamant about it, but just wondering, will it always appear to succeed with the semicolons and ‘exit 0’? would it not be better to use && between the commands? I’m not familiar with _run_cmd() call.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I have tested locally. This not how configuration should be dealt- hardcoding(I think that needs to be a separate task). I tweaked the existing code to add new classes that we worked on.
Generate documentation for infer package
Generate documentation for infer package
Generate documentation for infer package
Generate documentation for infer package
Description
Generate Scala documentation for infer package. Currently documentation script generates only for the core package.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments