Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[MXNET-16] [DO NOT MERGE] Move mshadow/ps-lite/dlpack to 3rdparty #10132

Closed
wants to merge 10 commits into from

Conversation

eric-haibin-lin
Copy link
Member

Description

(Brief description on what this PR is about)

Checklist

Essentials

  • Passed code style checking (make lint)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@eric-haibin-lin eric-haibin-lin changed the title [MXNET-16] [DO NOT MERGE] Move submodules to 3rdparty [MXNET-16] [DO NOT MERGE] Move mshadow/ps-lite/dlpack to 3rdparty Mar 16, 2018
piiswrong pushed a commit that referenced this pull request Mar 22, 2018
* move

* update cmake/make

* remove commment

* update license

* ps-lite move

* update license

* move mshadow for make

* mshadow cmake

* update license

* update readme

* Update Jenkinsfile

* update license file with paths
ashokei pushed a commit to ashokei/incubator-mxnet that referenced this pull request Mar 27, 2018
…he#10138)

* move

* update cmake/make

* remove commment

* update license

* ps-lite move

* update license

* move mshadow for make

* mshadow cmake

* update license

* update readme

* Update Jenkinsfile

* update license file with paths
jinhuang415 pushed a commit to jinhuang415/incubator-mxnet that referenced this pull request Mar 30, 2018
…he#10138)

* move

* update cmake/make

* remove commment

* update license

* ps-lite move

* update license

* move mshadow for make

* mshadow cmake

* update license

* update readme

* Update Jenkinsfile

* update license file with paths
rahul003 pushed a commit to rahul003/mxnet that referenced this pull request Jun 4, 2018
…he#10138)

* move

* update cmake/make

* remove commment

* update license

* ps-lite move

* update license

* move mshadow for make

* mshadow cmake

* update license

* update readme

* Update Jenkinsfile

* update license file with paths
zheng-da pushed a commit to zheng-da/incubator-mxnet that referenced this pull request Jun 28, 2018
…he#10138)

* move

* update cmake/make

* remove commment

* update license

* ps-lite move

* update license

* move mshadow for make

* mshadow cmake

* update license

* update readme

* Update Jenkinsfile

* update license file with paths
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant