This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
test_operator.test_binary_math_operators has fixed seed that can mask flakiness #11712
Closed
Description
The unit test in title have been using fixed seed to mask flakiness. Suggested action:
- Evaluate whether the test is flaky without fixed seed. If not, remove seed. Else move to 2
- If test is flaky, determine whether it's an actual uncaught edge case. If so, fix the operator. Else move to 3
- If numerical instability is inevitable, adjust tolerance level appropriately.