Skip to content

Conversation

@sultan
Copy link
Contributor

@sultan sultan commented Nov 29, 2022

This PR can be merged, If wanted to port (to 3.9.x) the fix for https://issues.apache.org/jira/browse/MNG-7559
intention is:

  • 1.0.0.RC1 < 1.0.0-RC2
  • ( edr, pfd, etc.) < final, ga, release
  • 9.4.1.jre16 > 9.4.1.jre16-preview

following semver rules should be encouraged, natural ordering is used without the need to hard code strings, except for hard coded qualifiers 'a', 'b', 'm', 'cr', 'snapshot', 'final', 'ga', 'release', '' and 'sp':

  • alpha = a < beta = b < milestone = m < rc = cr < 'snapshot' < '' = 'final' = 'ga' = 'release' < 'sp'

the documentation should discourage the usage of 'CR', 'final', 'ga', 'release' and 'SP' qualifiers.
Maven Central should begin to reject new artifact using CR and SP qualifiers.


Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MNG-XXX] SUMMARY, where you replace MNG-XXX
    and SUMMARY with the appropriate JIRA issue. Best practice is to use the JIRA issue
    title in the pull request title and in the first line of the commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the Core IT successfully.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@sultan sultan marked this pull request as ready for review November 29, 2022 14:09
@sultan sultan force-pushed the comparison-3.9.x branch 2 times, most recently from 85b627a to 1038ace Compare December 13, 2022 13:53
@sultan sultan mentioned this pull request Dec 16, 2022
8 tasks
@sultan
Copy link
Contributor Author

sultan commented Dec 16, 2022

this is a backport from maven 4 to maven 3:

the quoted PR had successful result on CI. any help appreciated on passing this PR results

@michael-o
Copy link
Member

@sultan Commit on master reverted. Let's start fresh and correctly on master first.

@sultan
Copy link
Contributor Author

sultan commented Dec 20, 2022

@sultan Commit on master reverted. Let's start fresh and correctly on master first.

Done on master

@sultan sultan force-pushed the comparison-3.9.x branch 3 times, most recently from b3f6ed1 to 4cf108b Compare December 22, 2022 11:02
@michael-o
Copy link
Member

Closing this since it does not qualify for 3.x.

@jira-importer
Copy link

Resolve #8891

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants