Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming of ArtifactCoordinate.getVersion() + documentation #1662

Merged
merged 7 commits into from
Aug 27, 2024

Conversation

gnodet
Copy link
Contributor

@gnodet gnodet commented Aug 18, 2024

  • use plural for coordinates
  • rename ArtifactCoordinates.getVersion() as getVersionConstraint().
  • remove LATEST and SNAPSHOT from documentation since they are deprecated.
  • opportunistic addition of some missing @Override annotations.
  • introduce DownloadedArtifact, DownloadedDependency and ProducedArtifact
  • more javadoc

@gnodet gnodet marked this pull request as draft August 18, 2024 07:30
@gnodet gnodet changed the title getVersionConstraint + doc Renaming of ArtifactCoordinate.getVersion() + documentation Aug 18, 2024
@gnodet
Copy link
Contributor Author

gnodet commented Aug 22, 2024

Supersedes #1640

desruisseaux and others added 7 commits August 27, 2024 09:21
@gnodet gnodet force-pushed the refactor/getVersionConstraint branch from 22f4881 to 92b9e45 Compare August 27, 2024 07:36
@gnodet gnodet requested a review from cstamas August 27, 2024 07:37
@gnodet gnodet marked this pull request as ready for review August 27, 2024 07:49
Copy link
Member

@cstamas cstamas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it!

@gnodet gnodet added this to the 4.0.0-beta-4 milestone Aug 27, 2024
@gnodet gnodet merged commit 30dc812 into apache:master Aug 27, 2024
13 checks passed
@gnodet gnodet deleted the refactor/getVersionConstraint branch August 30, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants