[MNG-8192] Consistently throw InvalidArtifactRTException for invalid #1637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwin
commented
Aug 9, 2024
| @@ -202,6 +203,9 @@ private static Restriction parseRestriction(String spec) throws InvalidVersionSp | |||
| } | |||
|
|
|||
| public static VersionRange createFromVersion(String version) { | |||
| if (DefaultArtifact.empty(version)) { | |||
There was a problem hiding this comment.
Or should we throw here for null/empty string? If so, which exception?
coordinates This fixes throwing NPE for version being null.
kwin
force-pushed
the
feature/defaultartifacthandler-consistent-exceptions
branch
from
fa05cf9
to
b2f0924
Compare
pzygielo
reviewed
Aug 10, 2024
| assertThrows( | ||
| InvalidArtifactRTException.class, | ||
| () -> new DefaultArtifact( | ||
| groupId, artifactId, (VersionRange) null, scope, type, classifier, artifactHandler, false)); |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
coordinates
This fixes throwing NPE for version being null.
Following this checklist to help us incorporate your
contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
[MNG-XXX] SUMMARY,where you replace
MNG-XXXandSUMMARYwith the appropriate JIRA issue.[MNG-XXX] SUMMARY.Best practice is to use the JIRA issue title in both the pull request title and in the first line of the commit message.
mvn clean verifyto make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.