Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNG-8061] Maven: Require Java 17 #1430

Merged
merged 1 commit into from
Mar 3, 2024
Merged

[MNG-8061] Maven: Require Java 17 #1430

merged 1 commit into from
Mar 3, 2024

Conversation

bmarwell
Copy link
Contributor

@bmarwell bmarwell commented Feb 27, 2024

** ✅ The vote on Java 17 for Maven 4 has passed.**

However, the vote was not for this PR in particular (code vote), but rather
a procedural vote.


Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MNG-XXX] SUMMARY,
    where you replace MNG-XXX and SUMMARY with the appropriate JIRA issue.
  • Also format the first line of the commit message like [MNG-XXX] SUMMARY.
    Best practice is to use the JIRA issue title in both the pull request title and in the first line of the commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the Core IT successfully.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@bmarwell bmarwell marked this pull request as ready for review March 2, 2024 12:49
@bmarwell
Copy link
Contributor Author

bmarwell commented Mar 2, 2024

Related: apache/maven-site#495

@bmarwell bmarwell merged commit 2bfa3a8 into master Mar 3, 2024
28 checks passed
@bmarwell bmarwell deleted the MNG-8061_java17 branch March 3, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants