Docs xmlnode deprecations followup #11576
Conversation
Adds consistent Javadoc deprecation rationale and replacement references for deprecated XmlNode constants and methods. No functional behavior is changed.
anukalp2804
force-pushed
the
docs-xmlnode-deprecations-followup
branch
from
7d8333e to
b159b3d
Compare
|
Hi @desruisseaux , kindly requesting a review when time permits. |
|
Friendly reminder — this PR has been idle for a few weeks. |
| String CHILDREN_COMBINATION_MODE_ATTRIBUTE = XmlService.CHILDREN_COMBINATION_MODE_ATTRIBUTE; | ||
|
|
||
| /** | ||
| * @deprecated since 4.0.0. |
There was a problem hiding this comment.
I don't know if we need to say "since 4.0.0." Will the annotation add this?
| Object inputLocation(); | ||
|
|
||
| // Deprecated methods that delegate to new ones | ||
| /** |
There was a problem hiding this comment.
I consider these deprecation mistaken and unnecessary, and would prefer to revert them all before release. The original method names were just fine
There was a problem hiding this comment.
This is an unrelated change that should not be in this PR
|
@elharo Thanks for the review. |
3 participants
This pull request completes the deprecation documentation for XmlNode
constants and methods by adding consistent Javadoc rationale and
explicit replacement references.
No functional behavior is changed.
Following this checklist to help us incorporate your
contribution quickly and easily:
Note that commits might be squashed by a maintainer on merge.
This may not always be possible but is a best-practice.
mvn verifyto make sure basic checks pass.A more thorough check will be performed on your pull request automatically.
If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.