[MNG-8672] Maven 4 CLI substitutes variable when single quoted

[jira-importer]

Alexis Tual opened MNG-8672 and commented

When executing this command line:

 

placeholder=foo mvn clean verify '-DsomeProp=${placeholder}'

 

Then we get:

• Maven 3:  someProp equals to ${placeholder}

• Maven 4.0.0-rc-4-SNAPSHOT (5426073) :  someProp equals to foo

The single quote implies the variable should not be substituted, in that sense Maven 3 seems to be the correct behavior.

It's due to this change. 

---

Affects: 4.0.0-rc-4

[jira-importer]

Michael Osipov commented

I knew that the offending change is a problem.

[jira-importer]

Alexis Tual commented

I've fixed the bug description to reflect what we see in our regression tests. We don't know if it's a use case or not; we can adapt our tests, but we just wanted to report this regression.

[guylabs]

@michael-o What is the state here? Can this be fixed for the upcoming Maven 4 RC version as it's a regression?

[michael-o]

@michael-o What is the state here? Can this be fixed for the upcoming Maven 4 RC version as it's a regression?

I can't tell you. I stopped working on Maven Core more than a year ago and lost complete track.

[alextu]

@michael-o What is the state here? Can this be fixed for the upcoming Maven 4 RC version as it's a regression?

@gnodet @cstamas any insights on this?

[guylabs]

@gnodet @cstamas any update on this?

[cstamas]

[cstamas@angeleyes tmp]$ placeholder=foo mvn -X -V help:evaluate -Dexpression=someProp '-DsomeProp=${placeholder}'
Apache Maven 4.1.0-SNAPSHOT (74ef127617fd8264110ac25346a4c3d200645f8d)
Maven home: /home/cstamas/.sdkman/candidates/maven/latest-master
Java version: 21.0.9, vendor: Eclipse Adoptium, runtime: /home/cstamas/.sdkman/candidates/java/21.0.9-tem
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "6.17.12-300.fc43.x86_64", arch: "amd64", family: "unix"
Command line: /home/cstamas/.sdkman/candidates/java/21.0.9-tem/bin/java --enable-native-access=ALL-UNNAMED -classpath /home/cstamas/.sdkman/candidates/maven/latest-master/boot/plexus-classworlds-2.9.0.jar -Dclassworlds.conf=/home/cstamas/.sdkman/candidates/maven/latest-master/bin/m2.conf -Dmaven.home=/home/cstamas/.sdkman/candidates/maven/latest-master -Dmaven.mainClass=org.apache.maven.cling.MavenCling -Dlibrary.jline.path=/home/cstamas/.sdkman/candidates/maven/latest-master/lib/jline-native -Dmaven.multiModuleProjectDirectory=/home/cstamas/tmp org.codehaus.plexus.classworlds.launcher.Launcher -X -V help:evaluate -Dexpression=someProp -DsomeProp=${placeholder}

w/ PR #11609