Proposal to fix support for mirrors

[cstamas]

This change relies on reusing existing API that can return proper URL (as set by user by ANY means in Maven config) to resolve from. PR contains also some cleanup.

Fixes #396
Supersedes #397

[yeikel]

Thank you for this, If this is better solution I am all for it.

Moreover, if repo ID is made configurable as well, it could be used to pull (needs more code; for that you would need to pull exec req repo by ID, and use that instead, and not craft central RemoteRepository instance) reposes like ID "my-corpo-repo" from settings and use that instead.

Sorry, I’m not familiar with this and I’m unsure what the next steps are or what you mean with this.

For what is worth, I built and tested this locally and it seems to fix my original bug report, so I'd be happy to have this as an starting solution

[INFO] --- wrapper:3.3.5-SNAPSHOT:wrapper (default-cli) @ simudyne-maven-java ---
[INFO] Unpacked only-script type wrapper distribution org.apache.maven.wrapper:maven-wrapper-distribution:zip:only-script:3.3.5-SNAPSHOT
[INFO] Determined repo URL to use as https://maven-central.storage.googleapis.com/maven2
[INFO] Configuring .mvn/wrapper/maven-wrapper.properties to use Maven 3.9.9 and download from https://maven-central.storage.googleapis.com/maven2

[cstamas]

From ASF CI:

Caused by: java.security.cert.CertificateNotYetValidException: NotBefore: Tue Feb 03 22:19:18 UTC 2026
    at sun.security.x509.CertificateValidity.valid (CertificateValidity.java:178)
    at sun.security.x509.X509CertImpl.checkValidity (X509CertImpl.java:534)
    at sun.security.provider.certpath.BasicChecker.verifyValidity (BasicChecker.java:190)

Weird.

[manandbytes]

To fully utilize Mockito Extension, IIRC:

• @org.mockito.Mock on non-final RepositorySystem and mockRepositorySystemSession, no need to initialize them
• no need to initialize wrapperMojo
• WrapperMojoTest() should became @BeforeEach void setUp(), method name could be any
• any(RepositorySystemSession.class) sould become same(mockRepositorySystemSession)

But this would fail userSuppliedRepoUrlGetsTrailingSlashTrimmed with:

org.mockito.exceptions.misusing.UnnecessaryStubbingException: 
Unnecessary stubbings detected.
Clean & maintainable test code requires zero unnecessary code.
Following stubbings are unnecessary (click to navigate to relevant line of code):
  1. -> at org.apache.maven.plugins.wrapper.WrapperMojoTest.setUp(WrapperMojoTest.java:45)
Please remove unnecessary stubbings or use 'lenient' strictness. More info: javadoc for UnnecessaryStubbingException class.

To fix this, @Mock(strictness = Mock.Strictness.LENIENT) RepositorySystem mockRepositorySystem

[cstamas]

Thanks!

[github-actions]

@cstamas Please assign appropriate label to PR according to the type of change.