Skip to content

Conversation

@bmarwell
Copy link
Contributor

@bmarwell bmarwell commented Feb 9, 2024

  • first commit tries to fixes the problem, except I actually used - 2 instead of - 1
  • Refactored the methods a bit to make them easier to test
  • Added a few tests for the most common cases
  • Opened a field and method for testing to protected
  • Don't use too short repo URLs where not even the protocol could fit.

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MWRAPPER-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace MWRAPPER-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@bmarwell bmarwell merged commit 1df6620 into master Mar 6, 2024
@bmarwell bmarwell deleted the MWRAPPER-86_trim_repourl_slash branch March 6, 2024 09:09
@jira-importer
Copy link

Resolve #208

1 similar comment
@jira-importer
Copy link

Resolve #208

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants