Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references to very old versions of surefire and TestNG #723

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

elharo
Copy link
Contributor

@elharo elharo commented Mar 4, 2024

TestNG 5 is circa 2010. Focus on what the current version does.

TestNG 5 is circa 2010. Focus on what the current version does.
@elharo elharo requested a review from michael-o March 4, 2024 15:06
@elharo
Copy link
Contributor Author

elharo commented Mar 4, 2024

Not sure what this is about. Probably flaky but I'll take a look:

2024-03-04T16:53:19.6293270Z [INFO] Results:
2024-03-04T16:53:19.6293780Z [INFO]
2024-03-04T16:53:19.6294100Z [ERROR] Failures:
2024-03-04T16:53:19.6299420Z [ERROR] Surefire1144XmlRunTimeIT.testXmlRunTime:52
2024-03-04T16:53:19.6300810Z Expected: is a value equal to or greater than <1.6F>
2024-03-04T16:53:19.6301930Z but: <1.599F> was less than <1.6F>
2024-03-04T16:53:19.6302850Z [INFO]
2024-03-04T16:53:19.6303680Z [ERROR] Tests run: 1015, Failures: 1, Errors: 0, Skipped: 135
2024-03-04T16:53:19.6304780Z [INFO]

@rmannibucau
Copy link
Contributor

rmannibucau commented Mar 4, 2024

@elharo currentTimeMillis (surefire1144.Test1#sleep), I think you should feel free to add some tolerance ~50ms in assertThat( xmlTime, is(greaterThanOrEqualTo( 1.6f ) ) ); assertion, in particular for windows which is even more flaky than linux for this call

@elharo elharo merged commit 1d6dcf5 into master Mar 5, 2024
38 checks passed
@elharo elharo deleted the elharo-patch-1 branch March 5, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants