Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes [SUREFIRE-1516]: Poor performance in reuseForks=false #253

Closed
wants to merge 3 commits into from
Closed

Fixes [SUREFIRE-1516]: Poor performance in reuseForks=false #253

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2fbe44f
Fixes [SUREFIRE-1516]: Forked JVM should not block in IO to read more…
jon-bell Nov 11, 2019
06c74da
Make pointless change to comment to re-trigger build
jon-bell Dec 9, 2019
1364c62
Add changes suggested in review
jon-bell Dec 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions surefire-api/src/main/java/org/apache/maven/surefire/booter/CommandReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -412,6 +412,10 @@ public void run()
CommandReader.this.wakeupIterator();
callListeners( command );
break;
case BYE_ACK:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not very elegant solution.
In the ForkedBooter the listener is already registered commandReader.addByeAckListener( new CommandListener() , see the line 356. See the next comment.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing I do not understand is why this change cause IT failure on macOS.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great to reproduce it with several runs of the build.

//After SHUTDOWN no more commands can come. Hence, do NOT go back to blocking in I/O
callListeners( command );
return;
default:
callListeners( command );
jon-bell marked this conversation as resolved.
Show resolved Hide resolved
break;
Expand Down