-
Notifications
You must be signed in to change notification settings - Fork 543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SUREFIRE-1194] reporter argument does not work for TestNG #107
Conversation
@juherr |
82c2a51
to
1a86928
Compare
@juherr the build is successful, I will check the changes. |
@juherr Can you add an integration test. I guess there is another API for reporter so that maybe we are missing one of them in our integration tests (testng 6.0). |
@Tibor17 I tried to add some test cases in Do you think I can add a method into Or maybe you can point me a test that already try different testng versions? |
You can override the TestNG version by I think you can extend the test |
Thank! I missed |
Current status:
Due to:
|
Alright I go it. You must use profile instead: |
I'm not sure to understand. |
6.9.9 works in my dummy project, then yes. Latest greatest. On Fri, Nov 27, 2015 at 8:10 PM, Julien Herr notifications@github.com
Cheers |
@juherr Try to commit what you have and I will check it out. Overriding last commit is just fine. |
Some artifacts was corrupted before. Now, they are the same than central. For 5.14.3:
But I don't see what's wrong with the pom but it explains the NoClassDefFound. For 5.14.2:
For 5.13:
|
I got it for 5.13 and 5.14.2: like reporter, listener attribute has changed too. I'm open for help with 5.14.3 |
Your IT has this POM |
As you proposed before |
It's hard to debug the IT because @after cleaned up previous tests in
This means you can parameterize |
@juherr Please mention the configuration of reported in surefire documentation. |
http://search.maven.org/#artifactdetails%7Corg.testng%7Ctestng%7C5.14.3%7Cjar
Any idea how to fix it or should we consider 5.14.3 as broken? |
We can add system-dependency to the pom.xml of IT and add guice-2.0.jar on On Sun, Nov 29, 2015 at 5:03 PM, Julien Herr notifications@github.com
Cheers |
Current status: 5.14.3The jar is still available:
It could work for 5.14.4 and 5.14.5, but the 5.14.4 test seems to work without this jar.
I supposed they don't: 5.14.6 and later replaced previous 5.14.x, and there is no more support on so old versions. 5.13 & 5.14.2Fun part for the listener attribute:
But, even fixed, there is an issue in TestNG with listener: |
@juherr |
Yes, decide something :) I see 2 options:
|
In fact, |
Let me see tomorrow or on Tuesday. |
@juherr |
Should failsafe fail with bad version, at least 5.14.3 which can't work at all? I think it should.
Ok, I will. |
@juherr What about to replace |
It won't work because TestNG need a `List in these 2 versions.
For sure, and I have no idea how much it will cost. For example, I didn't check, if we use a recent version, if |
@juherr I updated the comment. I don't mean this weekend. We still have one week left. |
@Tibor17 Done. Are the commits ok for you, or do you want I try to squash and/or reword them? |
Thx, try to squash them. On Tue, Dec 8, 2015 at 11:21 AM, Julien Herr notifications@github.com
Cheers |
… later Improve tests Change type for the reporter param Run unit tests for TestNG Typo in TestNG513ConfiguratorTest Fix tests Update documentation Fail or warn with bad TestNG versions
I was about to push your commit and start the release Vote. Do not hesitate to express the Warning and message in According to the comment in your IT Version 5.14.5 is wrong? Treatment was to exclude guice artifact? |
@juherr Are you a committer at TestNG project? |
5.14.4 is not supposed to fail and excluding the bad dependency worked for me. |
@juherr I am running the build in command line. |
I'm open :)
I confirm it is working for me with maven 3.3.9 and 3.2.5.
Global result: But we can avoid the problem and block 5.14.4 and 5.14.5 by default, like we did it with 5.14.3. |
@juherr Please try to test with official Version Maven 3.0.5 which should be used in Surefire project. I used 3.2.1. I will try with 3.0.5 as well and let you know my findings. |
I have reproduced the issue and the error is really true because the
|
But I will try your process too. |
I've just followed your process and it's working well for me with I tried on 2 different computer too. |
I use Maven 3.3.9 like you use. Do you have this path I use Java 7 which is maybe the only one difference. I think Surefire has dependency resolution issue. |
After deleting both repositories and using maven 3.3.9 still bad result in |
Yes
Ok. But it is working well on my side with
With Java 7 and maven 3.0.5
Same result with Java 7 and maven 3.3.9. |
Did you delete both repositories?
|
Yes. |
@agudian |
@juherr |
@juherr |
@juherr |
@Tibor17 Ok. But I still don't understand why it is working on my computers: I don't have guice-2.0.jar and exclude it was enough. For my information, why did you revert String -> Object? |
Hm, that's strange but the important thing is that Jenkins CI did not fail the build and we continue straight ahead of the release of 1.9.1.
I changed that back because the underneath method uses Java Reflection API and does not have any restrictions regarding String - uses Object. Additionally did not need to call |
No description provided.