Skip to content

Conversation

@ascheman
Copy link
Contributor

These modules were missing in the graphics.

Additionally the modules were ordered (slightly)
lexicographically to make alignment
with apache-sources/default.xml easier.

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Your pull request should address just one issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
    Note that commits might be squashed by a maintainer on merge.
  • Run mvn site and examine output in target/site directory.
    Site will also be built on your pull request automatically and attached to GitHub Action result.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@Bukama
Copy link
Contributor

Bukama commented May 26, 2025

Not sure if they are needed. I remember we removed a lot of old stuff to not be included in the diagram anymore (see #615 )

@hboutemy
Copy link
Member

it has been intentional in the past to keep it simple, when it was a handwritten image
nowadays that it is generated, it's a choice to be done: is it really valuable? is it really "Maven sources"?

I need some time to review the visual result to decide...

@ascheman
Copy link
Contributor Author

To be honest, I didn't check whether it is really part of Maven (but can easily do so). If these components are not part (as dependencies) of any other Maven project, they perhaps could be dropped from sources (aggregator and repo manifest) as well?

@Bukama
Copy link
Contributor

Bukama commented Jun 21, 2025

it has been intentional in the past to keep it simple, when it was a handwritten image nowadays that it is generated, it's a choice to be done: is it really valuable? is it really "Maven sources"?

I need some time to review the visual result to decide...

Looking at this PR after some weeks: Did you already find some time or do you need more? (Just to have a status on this PR)

These modules were missing in the graphics.

Additionally the modules were ordered (slightly)
lexicographically to make alignment
with apache-sources/default.xml easier.
@ascheman ascheman force-pushed the bugfix/add-missing-to-plexus branch from 5f59950 to 5fc82e6 Compare June 21, 2025 20:51
@Bukama
Copy link
Contributor

Bukama commented Aug 30, 2025

@hboutemy Did you find some time to sort your thoughts?

@Bukama
Copy link
Contributor

Bukama commented Oct 18, 2025

is it really "Maven sources"?

I argue that they are not. Maven committers don't have permissions for the plexus repositories. For me, the plexus artifacts are regular third party dependencies.

@hboutemy
Copy link
Member

do as you wish:

  • either consider this level of detail useful at Maven level
  • or simplify, keeping just "components" without details with a link to https://codehaus-plexus.github.io/ because this is where details are to be maintained

I won't fight any choice: it's a matter of taste, given the schema is now generated, every option is maintainable

I have a personal preference for the simplified view because we already have much in the schema at https://maven.apache.org/scm.html

think about what will help other the most in the future:

  • complete but complex
  • incomplete but simpler, to feel the structure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants