-
Couldn't load subscription status.
- Fork 286
Add missing modules to Maven "plexus" overview #794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add missing modules to Maven "plexus" overview #794
Conversation
|
Not sure if they are needed. I remember we removed a lot of old stuff to not be included in the diagram anymore (see #615 ) |
|
it has been intentional in the past to keep it simple, when it was a handwritten image I need some time to review the visual result to decide... |
|
To be honest, I didn't check whether it is really part of Maven (but can easily do so). If these components are not part (as dependencies) of any other Maven project, they perhaps could be dropped from sources (aggregator and repo manifest) as well? |
Looking at this PR after some weeks: Did you already find some time or do you need more? (Just to have a status on this PR) |
These modules were missing in the graphics. Additionally the modules were ordered (slightly) lexicographically to make alignment with apache-sources/default.xml easier.
5f59950 to
5fc82e6
Compare
|
@hboutemy Did you find some time to sort your thoughts? |
I argue that they are not. Maven committers don't have permissions for the plexus repositories. For me, the plexus artifacts are regular third party dependencies. |
|
do as you wish:
I won't fight any choice: it's a matter of taste, given the schema is now generated, every option is maintainable I have a personal preference for the simplified view because we already have much in the schema at https://maven.apache.org/scm.html think about what will help other the most in the future:
|
These modules were missing in the graphics.
Additionally the modules were ordered (slightly)
lexicographically to make alignment
with apache-sources/default.xml easier.
Following this checklist to help us incorporate your
contribution quickly and easily:
Note that commits might be squashed by a maintainer on merge.
mvn siteand examine output intarget/sitedirectory.Site will also be built on your pull request automatically and attached to GitHub Action result.
If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.