[MSHADE-252] - Make source shading respect package/class name excludes #88
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Make source shading respect package/class name excludes
Fixes MSHADE-252.
Until now, there was a naive global search + replace for mapping
<pattern>
to<shadedPattern>
, even if the corresponding packages are to be ignored. This works for binary JARs, but was completely broken for source JARs.See also my related comment in MSHADE-252.
With this fix, on the one hand string replacement in source files works for both "dotty" strings like
my.package.name.Foo
and "slashy" ones like/my/package/name/resource.properties
. On the other hand, source files are now being parsed<pattern>
match by match and for each match the excludes list will be checked and replacements only performed if the corresponding matched package name is not on the excludes list. This is of course slower than just a rawreplaceAll(..)
, but it produces correct results.2. Make relocation ex-/include matching more lenient, accepting
.**
tooActually, class patterns are supposed to should just use
foo.bar.*
ending with a single asterisk, but some users mistake them for path patterns likemy/path/**
, so let us be a bit more lenient here.See also my related comment in MSHADE-252.
I have just sent my Contributor License Agreement to the Apache secretary's e-mail address. I hope is shall be processed quickly.
Following this checklist to help us incorporate your
contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
[MSHADE-XXX] - Fixes bug in ApproximateQuantiles
,where you replace
MSHADE-XXX
with the appropriate JIRA issue. Best practiceis to use the JIRA issue title in the pull request title and in the first line of the
commit message.
mvn clean verify
to make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
mvn -Prun-its clean verify
).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.