[MRESOLVER-685] Connector pipelining #679
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ability to "pipe" connectors one onto another in controlled and configured fashion. The ide is following: - first (actually connecting to remote) connector is chosen as today (based on priority) - next, new type of factories PipelinedRepositoryConnectorFactory is ordered (by priority) and they can (but does not have to) wrap the delegate in configured order. Factored out existing RRF connector into new factory, and introduced another OfflinePRCF, as so far, "resolver offline" was in fact managed at different spots, and user was still able to circumvent offline setting. This now connector now wraps connector and refuses going remote if session if offline. --- https://issues.apache.org/jira/browse/MRESOLVER-685
Here, instead of "selecting winner" it in fact works as order.
but now we have "always online repositories" as well.
|
Resolve #1361 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ability to "pipe" connectors one onto another in controlled and configured fashion.
The ide is following:
Factored out existing RRF connector into new factory, and introduced another OfflinePRCF, as so far, "resolver offline" was in fact managed at different spots, and user was still able to circumvent offline setting. This now connector now wraps connector and refuses going remote if session if offline.
Vanilla resolver does this:
offline( rrf( basic( repo ) ) )Ultimate goal, envision this:
offline( mimir( sigcheck( rrf( basic( repo ) ) ) ) )https://issues.apache.org/jira/browse/MRESOLVER-685