Check all project parents for SCM information. #1421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Introduced in: |
kwin
approved these changes
Nov 19, 2025
Member
kwin
left a comment
kwin
left a comment
There was a problem hiding this comment.
Thanks for picking this up. Just minor remarks on comments. Otherwise LGTM
...e-manager/src/main/java/org/apache/maven/shared/release/phase/RewritePomsForBranchPhase.java
Outdated
Show resolved
Hide resolved
...-manager/src/main/java/org/apache/maven/shared/release/phase/RewritePomsForReleasePhase.java
Outdated
Show resolved
Hide resolved
slawekjaranowski
force-pushed
the
gh-1420
branch
from
d3963ce to
220a17d
Compare
During the project transformation, we need to verify all parent projects. Otherwise, modules at deeper levels may have an SCM tag added unnecessarily. fix apache#1420
slawekjaranowski
force-pushed
the
gh-1420
branch
from
220a17d to
db93204
Compare
|
@slawekjaranowski Please assign appropriate label to PR according to the type of change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the project transformation, we need to verify all parent projects.
Otherwise, modules at deeper levels may have an SCM tag added unnecessarily.
fix #1420