[MPLUGINTESTING-76] Upgrade Plexus Archiver from 4.3.0 to 4.6.1 (broken api in 4.4.0) #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-o
approved these changes
Feb 15, 2023
gnodet
changed the title
gnodet
force-pushed
the
up-plexus-archiver
branch
from
4c8711c
to
c98eb4d
Compare
| @@ -273,17 +273,9 @@ public void createUnpackableFile(Artifact artifact, File destFile) | |||
| archiver.setDestFile(destFile); | |||
| archiver.addFile(srcFile, getUnpackableFileName(artifact)); | |||
|
|
|||
| try { | |||
| setVariableValueToObject(archiver, "logger", new SilentLog()); | |||
There was a problem hiding this comment.
Looks like SilentLog class is no more used ... maybe we can remove it, or at least deprecate
There was a problem hiding this comment.
If it is in any relation to Plexus Logger, then definitely
There was a problem hiding this comment.
It's used in various places within the ASF and there's no real replacement. While maven components should be switched to SLF4j, the plugin side is not completely sorted (as afaik, the org.slf4j package is not exported by the maven core class loader.
So I've raised an issue but I'd keep it as is until it's sorted.
There was a problem hiding this comment.
slawekjaranowski
approved these changes
Feb 15, 2023
gnodet
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.