Conversation
slachiewicz
approved these changes
Dec 18, 2024
Member
slachiewicz
left a comment
slachiewicz
left a comment
There was a problem hiding this comment.
Looks like it could be also simple Strings building
Contributor
Author
You mean build the string and not write a file at all? I wondered that too. Maybe. That might be a bigger change, or have some inobvious bits. It would be better if we could do that. |
Contributor
Author
|
Even better would be to invoke jmod through an API instead of the command line. But I don't know that we should let the perfect be the enemy of the good. The existing code is broken. This at least fixes some of that. |
Contributor
Author
|
I'm taking a stab at removing the I/O completely. The sticking point is that the integration tests are based on very precise log messages, a common antipattern. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In particular avoid PrintStream, which ignores I/O errors and hasn't been needed since Java 1.1