[MJMOD-20] set jmod --main-class argument if it is set.#1
Merged
rfscholte merged 5 commits intoapache:masterfrom Jan 18, 2019
andretadeu:master
Merged
[MJMOD-20] set jmod --main-class argument if it is set.#1rfscholte merged 5 commits intoapache:masterfrom andretadeu:master
rfscholte merged 5 commits intoapache:masterfrom
andretadeu:master
Conversation
rfscholte
requested changes
Jan 17, 2019
src/main/java/org/apache/maven/plugins/jmod/JModCreateMojo.java
Outdated
Show resolved
Hide resolved
…ment section to use the default ones. Refactor test to become more Groovyish. Set 9+ in invoker.java.version, replacing 1.9+. Set invoker.goals to 'package' only. Use StringUtils.isNotBlank instead of manual check for 'mainClass' parameter.
Contributor
Author
|
@rfscholte Done. |
|
Resolve #57 |
1 similar comment
|
Resolve #57 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
This pull request sets the parameter --main-class if it was set in:
otherwise, if I am not able to set, I may not run jmod in modules that contains a Main class.
Thanks,
André Tadeu de Carvalho