[MJAVADOC-642] Setting maven.javadoc.isoffline seems to have no effect

[jira-importer]

Thomas Cunningham opened MJAVADOC-642 and commented

I'm trying to work around MJAVADOC-641 and the proxy issues that we are having, and I'd like to set isOffline to true.     I tried to do this my setting -Dmaven.javadoc.isOffline=true in my maven invocation, and it doesn't seem to take effect.    Setting isOffline to true within the <configuration/> allows my build to succeed.

Am I using the wrong command line property for isOffline?

---

Affects: 3.1.1

Remote Links:

• GitHub Pull Request #232
  
• GitHub Pull Request #238
  
• GitHub Pull Request #77
  

1 votes, 6 watchers

[jira-importer]

Michael Osipov commented

I can't find this property. Can you show me?

[jira-importer]

Thomas Cunningham commented

Michael Osipov I found it mentioned here : 

https://maven.apache.org/plugins/maven-javadoc-plugin/javadoc-mojo.html

[jira-importer]

Michael Osipov commented

It is only mentioned in <links>, but there is no reference. That seems odd.

[jira-importer]

Thomas Cunningham commented

It's here, but I'm not sure how to set it

https://github.com/apache/maven-javadoc-plugin/blob/master/src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java#L342-L343

[jira-importer]

Michael Osipov commented

There is your problem. The documentation is bad/incomplete and you did pass -Dmaven.javadoc.isOffline. The property is -Dsettings.offline. Please retry.

[jira-importer]

Thomas Cunningham commented

I'm not seeing -Dsettings.offline work.    I'm trying to set that to true, and it doesn't seem like it's being respected.    If I hard code <isOffline>true</isOffline> into my configuration, that works, but setting -Dsettings.offLine=true doesn't seem to work.

Here's a pom.xml example that I'm working with : 

https://github.com/apache/camel/blob/master/core/camel-util/pom.xml

[jira-importer]

Michael Osipov commented

OK, I need to look at this.

[jira-importer]

Michael Osipov commented

Can you please provide the debug output for your plugin invocation as well as the @ files generated?

 

[jira-importer]

Benjamin Marwell commented

Here is a sample configuration:

<configuration>
            <links>
              <link>http://docs.oracle.com/javase/7/docs/api</link>
              <link>http://static.netty.io/3.5/api</link>
              <link>http://google-guice.googlecode.com/git/javadoc</link>
              <link>http://fasterxml.github.com/jackson-databind/javadoc/2.0.4</link>
              <link>https://developers.google.com/protocol-buffers/docs/reference/java</link>
            </links>
            <isOffline>true</isOffline>
            <detectJavaApiLink>true</detectJavaApiLink>
            <detectLinks>true</detectLinks>
            <detectOfflineLinks>true</detectOfflineLinks>
            <linksource>true</linksource>
</configuration>

Output behind proxy:

[WARN] Error fetching link: https://github.com/javaee/jaxb-spec/jaxb-api/apidocs. Ignored it.
[WARN] Error fetching link: http://www.slf4j.org/apidocs. Ignored it.
[WARN] Error fetching link: http://findbugs.sourceforge.net/apidocs. Ignored it.
[WARN] Error fetching link: http://cdi-spec.org/apidocs. Ignored it.
[WARN] Error fetching link: http://www.jqno.nl/equalsverifier/apidocs. Ignored it.
[WARN] Error fetching link: https://checkerframework.org/apidocs. Ignored it.
[WARN] Error fetching link: https://junit.org/junit5/apidocs. Ignored it.
[WARN] Error fetching link: https://junit.org/junit5/apidocs. Ignored it.
[WARN] Error fetching link: http://hamcrest.org/JavaHamcrest/apidocs. Ignored it.
[WARN] Error fetching link: https://github.com/mockito/mockito/apidocs. Ignored it.

[jira-importer]

Henning Schmiedehausen commented

The explanation above is wrong.

The "isOffline" setting is controlled by "${settings.offline}", which is part of the maven internal settings. It can not be controlled by -Dsettings.offline=true but by passing the -o parameter to maven.

Neither setting maven.javadoc.isOffline nor setting settings.offline on the command line has any effect.

Currently, the only way to run the javadoc plugin in offline mode is to pass the -o flag to maven itself. I will add a property setting in a PR and then close this issue as fixed.

[jira-importer]

Henning Schmiedehausen commented

as a side note, while <isOffline> works, it was never documented (it was intended for internal use). The next release (3.6.0) will expose a <offline> configuration setting that serves the same purpose. You may need to fix your build.