[MINSTALL-186] install-file fails when the file belongs to the local repository and using a localRepositoryPath

[jira-importer]

Romain Bioteau opened MINSTALL-186 and commented

To reproduce:

Assuming maven-deploy-plugin 3.0.0 EXISTS in your local repository:

❯ mvn org.apache.maven.plugins:maven-install-plugin:3.1.0:install-file -Dfile=$HOME/.m2/repository/org/apache/maven/plugins/maven-deploy-plugin/3.0.0/maven-deploy-plugin-3.0.0.jar -DlocalRepositoryPath=/tmp/repo -Dversion=3.0.0 -DartifactId=maven-deploy-plugin -DgroupId=org.apache.maven.plugins -Dtype=jar
[INFO] Scanning for projects...
[INFO] 
[INFO] ------------------< org.apache.maven:standalone-pom >-------------------
[INFO] Building Maven Stub Project (No POM) 1
[INFO] --------------------------------[ pom ]---------------------------------
[INFO] 
[INFO] --- maven-install-plugin:3.1.0:install-file (default-cli) @ standalone-pom ---
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  0.164 s
[INFO] Finished at: 2022-11-25T19:12:32+01:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-install-plugin:3.1.0:install-file (default-cli) on project standalone-pom: Cannot install artifact. Artifact is already in the local repository.
[ERROR] 
[ERROR] File in question is: /home/romain/.m2/repository/org/apache/maven/plugins/maven-deploy-plugin/3.0.0/maven-deploy-plugin-3.0.0.jar
[ERROR] 
[ERROR] -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

---

Affects: 3.0.1, 3.1.0

Remote Links:

• GitHub Pull Request #49
  

[jira-importer]

Romain Bioteau commented

Related PR: #49

[jira-importer]

Piotr Zygielo commented

Using maven 3.8.6, I can't reproduce this

$ mvn org.apache.maven.plugins:maven-install-plugin:3.1.0:install-file -Dfile=$HOME/.m2/repository/org/apache/maven/plugins/maven-deploy-plugin/3.0.0/maven-deploy-plugin-3.0.0.jar -DlocalRepositoryPath=/tmp/repo -DgroupId=org.apache -DartifactId=test -Dpackaging=jar -Dversion=1.0

always completes with success:

[INFO] Scanning for projects...
[INFO] 
[INFO] ------------------< org.apache.maven:standalone-pom >-------------------
[INFO] Building Maven Stub Project (No POM) 1
[INFO] --------------------------------[ pom ]---------------------------------
[INFO] 
[INFO] --- maven-install-plugin:3.1.0:install-file (default-cli) @ standalone-pom ---
[INFO] Installing .../.m2/repository/org/apache/maven/plugins/maven-deploy-plugin/3.0.0/maven-deploy-plugin-3.0.0.jar to /tmp/repo/org/apache/test/1.0/test-1.0.jar
[INFO] Installing /tmp/maven-deploy-plugin-3.0.010112682731321406765.pom to /tmp/repo/org/apache/test/1.0/test-1.0.pom
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  0.524 s
[INFO] Finished at: 2022-11-25T17:04:19+01:00
[INFO] ------------------------------------------------------------------------

[jira-importer]

Romain Bioteau commented

Hi Piotr,
You should not change the artifact coordinates in your test.
I'm reproducing with maven 3.8.6 also with:

mvn org.apache.maven.plugins:maven-install-plugin:3.1.0:install-file -Dfile=$HOME/.m2/repository/org/apache/maven/plugins/maven-deploy-plugin/3.0.0/maven-deploy-plugin-3.0.0.jar -DlocalRepositoryPath=/tmp/repo

HTH
Romain

[jira-importer]

Piotr Zygielo commented

If not specified, plugin complains that they are missing. You shared no pom to start with, so I used no-pom.

Update reproduction steps.

[jira-importer]

Romain Bioteau commented

If not specified, plugin complains that they are missing.
I do not have such complaints on my side. The documentation only specify file as required.

You shared no pom to start with, so I used no-pom.
There is no need for a pom. The issue is when the target coordinates matches the source file coordinates, which is the default behavior of the goal (when pom file is archived in the META-INF/maven folder of the source jar).

I have updated the steps to reproduce, hoping it is more understandable.

Have a nice day/night.

[jira-importer]

Piotr Zygielo commented

I have updated the steps to reproduce, hoping it is more understandable. 

Thanks - I'm getting the same error now.