Skip to content

Comments

Prefer Guice injection#40

Merged
elharo merged 1 commit intomasterfrom
guice
Dec 23, 2024
Merged

Prefer Guice injection#40
elharo merged 1 commit intomasterfrom
guice

Conversation

@elharo
Copy link
Contributor

@elharo elharo commented Dec 19, 2024

I also de-injected two fields completely because there was no need to inject them. They already had a specific concrete type. They were injected just because.

@elharo elharo requested a review from slachiewicz December 19, 2024 23:18
@elharo elharo marked this pull request as ready for review December 20, 2024 09:49
@slachiewicz slachiewicz removed their request for review December 22, 2024 16:38
@elharo elharo requested a review from slachiewicz December 23, 2024 12:39
@elharo elharo merged commit 6ccaf95 into master Dec 23, 2024
@elharo elharo deleted the guice branch December 23, 2024 20:23
@slachiewicz slachiewicz added this to the 3.3.0 milestone Nov 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants